Exclude static metadata and viewport from error recovery prerender when cache-components is enabled

[gnoff]

These functions can be dynamic however in this mode we are trying to recover on the client so there is little point in attempting to resolve the http error recovery metadata since it might block us producing a shell. We now exclude these from the errore recovery RSC payload since we will recover the metadata on hydration in the browser.

[github-actions]

Failing test suites

Commit: d058ed1 | About building and testing Next.js

pnpm test-dev test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts (job)

• parallel-routes-and-interception > should not render the @children slot when the @slot is not found (DD)

Expand output

● parallel-routes-and-interception › should not render the @children slot when the @slot is not found

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  23 |     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
  24 |     const $ = await next.render$('/')
> 25 |     expect($('title').length).toBe(0)
     |                               ^
  26 |   })
  27 |
  28 |   it('should render the title once for the non-existed route', async () => {

  at Object.toBe (e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts:25:31)

pnpm test-dev test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts (job)

• parallel-routes-and-interception > should not render the @children slot when the @slot is not found (DD)

Expand output

● parallel-routes-and-interception › should not render the @children slot when the @slot is not found

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  23 |     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
  24 |     const $ = await next.render$('/')
> 25 |     expect($('title').length).toBe(0)
     |                               ^
  26 |   })
  27 |
  28 |   it('should render the title once for the non-existed route', async () => {

  at Object.toBe (e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts:25:31)

pnpm test-dev test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts (job)

• parallel-routes-and-interception > should not render the @children slot when the @slot is not found (DD)

Expand output

● parallel-routes-and-interception › should not render the @children slot when the @slot is not found

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  23 |     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
  24 |     const $ = await next.render$('/')
> 25 |     expect($('title').length).toBe(0)
     |                               ^
  26 |   })
  27 |
  28 |   it('should render the title once for the non-existed route', async () => {

  at Object.toBe (e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts:25:31)

pnpm test-start test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts (job)

• parallel-routes-and-interception > should not render the @children slot when the @slot is not found (DD)

Expand output

● parallel-routes-and-interception › should not render the @children slot when the @slot is not found

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  23 |     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
  24 |     const $ = await next.render$('/')
> 25 |     expect($('title').length).toBe(0)
     |                               ^
  26 |   })
  27 |
  28 |   it('should render the title once for the non-existed route', async () => {

  at Object.toBe (e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts:25:31)

pnpm test-dev test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts (job)

• parallel-routes-and-interception > should not render the @children slot when the @slot is not found (DD)

Expand output

● parallel-routes-and-interception › should not render the @children slot when the @slot is not found

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  23 |     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
  24 |     const $ = await next.render$('/')
> 25 |     expect($('title').length).toBe(0)
     |                               ^
  26 |   })
  27 |
  28 |   it('should render the title once for the non-existed route', async () => {

  at Object.toBe (e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts:25:31)

pnpm test-dev test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts (job)

• parallel-routes-and-interception > should not render the @children slot when the @slot is not found (DD)

Expand output

● parallel-routes-and-interception › should not render the @children slot when the @slot is not found

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  23 |     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
  24 |     const $ = await next.render$('/')
> 25 |     expect($('title').length).toBe(0)
     |                               ^
  26 |   })
  27 |
  28 |   it('should render the title once for the non-existed route', async () => {

  at Object.toBe (e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts:25:31)

pnpm test-dev test/development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts (job)

• instant-nav-panel > transitions between capture types > should avoid showing stale SPA state when reloading from a captured SPA state into captured MPA state (DD)

Expand output

● instant-nav-panel › transitions between capture types › should avoid showing stale SPA state when reloading from a captured SPA state into captured MPA state

locator.waitFor: Timeout 30000ms exceeded.
Call log:
  - waiting for locator('[data-testid="dynamic-skeleton"]') to be visible

  206 |     await browser
  207 |       .locator('[data-testid="dynamic-skeleton"]')
> 208 |       .waitFor({ state: 'visible', timeout: 30000 })
      |        ^
  209 |     await browser
  210 |       .locator('[data-testid="param-skeleton"]')
  211 |       .waitFor({ state: 'visible' })

  at waitFor (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:208:8)
  at Object.expectTargetPageMpaShell (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:579:13)

pnpm test-start test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts (job)

• parallel-routes-and-interception > should not render the @children slot when the @slot is not found (DD)

Expand output

● parallel-routes-and-interception › should not render the @children slot when the @slot is not found

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  23 |     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
  24 |     const $ = await next.render$('/')
> 25 |     expect($('title').length).toBe(0)
     |                               ^
  26 |   })
  27 |
  28 |   it('should render the title once for the non-existed route', async () => {

  at Object.toBe (e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts:25:31)

pnpm test-start test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts (job)

• parallel-routes-and-interception > should not render the @children slot when the @slot is not found (DD)

Expand output

● parallel-routes-and-interception › should not render the @children slot when the @slot is not found

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  23 |     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
  24 |     const $ = await next.render$('/')
> 25 |     expect($('title').length).toBe(0)
     |                               ^
  26 |   })
  27 |
  28 |   it('should render the title once for the non-existed route', async () => {

  at Object.toBe (e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts:25:31)

pnpm test-dev-turbo test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts (turbopack) (job)

• parallel-routes-and-interception > should not render the @children slot when the @slot is not found (DD)

Expand output

● parallel-routes-and-interception › should not render the @children slot when the @slot is not found

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  23 |     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
  24 |     const $ = await next.render$('/')
> 25 |     expect($('title').length).toBe(0)
     |                               ^
  26 |   })
  27 |
  28 |   it('should render the title once for the non-existed route', async () => {

  at Object.toBe (e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts:25:31)

pnpm test-start-turbo test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts (turbopack) (job)

• parallel-routes-and-interception > should not render the @children slot when the @slot is not found (DD)

Expand output

● parallel-routes-and-interception › should not render the @children slot when the @slot is not found

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  23 |     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
  24 |     const $ = await next.render$('/')
> 25 |     expect($('title').length).toBe(0)
     |                               ^
  26 |   })
  27 |
  28 |   it('should render the title once for the non-existed route', async () => {

  at Object.toBe (e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts:25:31)

[github-actions]

Stats cancelled

Commit: d058ed1
View workflow run

[unstubbable]

Looks like the title assertion in test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts needs to be adjusted.

[vercel]

Test assertion expect($('title').length).toBe(0) was changed unconditionally, but the <title> tag is only absent in cache-components mode — regular prod mode still renders it, causing the test to fail outside cache-components CI.

[unstubbable]

@gnoff I though you'd do the same check as here. That should work for both with and without cacheComponents, right?

[vercel]

Good point — using a browser.eval() + retry() approach like the new cache-components test would work in both modes since the title will be present client-side regardless (either from SSR or from hydration recovery). Either approach fixes the issue; I'll defer to @gnoff on which feels more appropriate here.