Skip to content

Add tests for intersect/union, limit, group by, order by, variable, list exprs#5061

Merged
Sophie-Xie merged 6 commits into
vesoft-inc:masterfrom
jievince:expr-tck
Dec 28, 2022
Merged

Add tests for intersect/union, limit, group by, order by, variable, list exprs#5061
Sophie-Xie merged 6 commits into
vesoft-inc:masterfrom
jievince:expr-tck

Conversation

@jievince
Copy link
Copy Markdown
Contributor

@jievince jievince commented Dec 15, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

By the way, fix #5112, fix #5114

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince changed the title add some tests for expr Add tests for intersect/union, limit, group by, order by, variable, list exprs Dec 26, 2022
@jievince jievince marked this pull request as ready for review December 26, 2022 09:14
@jievince jievince added the ready-for-testing PR: ready for the CI test label Dec 26, 2022
@jievince jievince force-pushed the expr-tck branch 2 times, most recently from 54a009c to 5c5aa21 Compare December 26, 2022 11:35
@Sophie-Xie Sophie-Xie added the priority/hi-pri Priority: high label Dec 27, 2022
Comment thread tests/tck/features/match/PipeAndVariable.feature
nevermore3
nevermore3 previously approved these changes Dec 27, 2022
Copy link
Copy Markdown
Contributor

@codesigner codesigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Comment thread tests/tck/features/match/PipeAndVariable.feature
Comment thread tests/tck/features/set/Set.feature
@Sophie-Xie Sophie-Xie merged commit 97f5186 into vesoft-inc:master Dec 28, 2022
@jievince jievince deleted the expr-tck branch December 28, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/hi-pri Priority: high ready-for-testing PR: ready for the CI test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experssion any/single/none/all in list has bugs Two statement which define the variable with same name cause the graphd to crash

5 participants