fix: dereference *string in fmt.Errorf for HaChassisGroup#36
Open
Dong Ma (larainema) wants to merge 1 commit intomainfrom
Open
fix: dereference *string in fmt.Errorf for HaChassisGroup#36Dong Ma (larainema) wants to merge 1 commit intomainfrom
Dong Ma (larainema) wants to merge 1 commit intomainfrom
Conversation
- Dereference lrp.HaChassisGroup to *lrp.HaChassisGroup in fmt.Errorf (govet: %q with *string) - Add nil check for gatewayPortInfo to return a proper error instead of panicking with nil pointer dereference when no gateway port is found Both issues were introduced in 162d467 (Sep 16, 2025). Signed-off-by: Dong Ma <dong.ma@vexxhost.com> Signed-off-by: Dong Ma <winterma.dong@gmail.com>
Dong Ma (larainema)
force-pushed
the
fix/govet-ha-chassis-group
branch
from
ad40e91 to
1630fbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI has been failing since commit 162d467 (Sep 16, 2025) due to a
goveterror:Both
golangci-lintandgo-testjobs fail because of this. This also causes StepSecurity PR #35 to fail.Fix
Dereference
lrp.HaChassisGroupto*lrp.HaChassisGroupin thefmt.Errorfcall at line 206, since the nil check is already done on line 203.