APP-14871: Add ReportConnectionMetadata RPC and client-side connection reporting#544
Open
danielbotros wants to merge 10 commits intoviamrobotics:mainfrom
Open
Conversation
Adds a new unary RPC and ICECandidateType enum to the signaling proto so that RDK clients can report which ICE candidate type was selected for a WebRTC connection. This enables the app to track per-org Twilio relay fallthrough without requiring any changes to the core ICE negotiation flow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…er dial After ICE successfully connects in dialWebRTC, calls the new ReportICECandidateSelected RPC on the signaling server as a best-effort fire-and-forget operation. The selected candidate type is determined by inspecting the WebRTC stats report for the nominated candidate pair. Relay candidates are classified as coturn_relay (URL contains viam.com/viaminternal) or twilio_relay (all other relay servers). This gives the app per-org visibility into Twilio relay fallthrough without changing ICE negotiation behavior. The RDK picks up this behavior automatically when goutils is updated — no separate RDK change required. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Mar 31, 2026
Removed check for unspecified ICE candidate type in reporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
APP-14871 Track coturn usage
ICECandidateTypeandSDKTypeenums and aReportConnectionMetadataunary RPC toSignalingServiceprotocoturn_relay, ortwilio_relaycoturn_relayif the TURN server URL containsviam.com/viaminternal, otherwisetwilio_relaydialWebRTC, callsReportConnectionMetadataon the signaling server as a best-effort fire-and-forget operation to record the successful attempt, candidate type, and SDK type (Go)Testing
Some logs were added and dial options messed with to turn off mDNS / ensure we connect through the local signaling server for this test.
viam-serverwith these changes + this change and a remoteviam-server.viam-serverThe candidate type and SDK type are sent to app in the
ReportConnectionMetadataRPC where they are recorded along with the org ID.