cli/overlay.sh: fix inverted yesno guard in __overlay_reset

[Dev-X25874]

Problem

__overlay_reset in cli/overlay.sh had an inverted confirmation guard.

yesno_cli returns 0 when the user types "yes" and 1 when they type
"no". The existing code used:

if yesno_cli "WARNING..."; then
    return
fi

This means a user confirming the reset ("yes") would silently abort,
while a user declining ("no") would trigger the destructive
reset_overlays call — the exact opposite of intent.

The TUI counterpart (tui/overlay/overlay.sh) and __overlay_install
in the same file both correctly use if ! yesno_cli as the abort
guard.

Fix

Add the missing ! on line 261:

if ! yesno_cli "WARNING..."; then
    return
fi

Test

Added cli/test/overlay_reset_test.sh which stubs all external
dependencies and asserts:

• answering "yes" calls reset_overlays exactly once
• answering "no" does not call reset_overlays

[djkabutar]

thanks for the PR, can you mention the fix in the commit message as well, it will be easier to track there. You can check previous commits for more reference.

[Dev-X25874]

Hey @djkabutar, done! Updated the commit message to follow the project's convention. Let me know if anything else needs changing.

[djkabutar]

you have made the changes but, you have created extra commit on top of the other commits & which is empty commit, which is not required, you need to rebase and reword the commits and force push it in order to reflect properly

[Dev-X25874]

@djkabutar done! Squashed all 3 commits into 1 clean commit. Let me know if anything else needs changing.

[Dev-X25874]

@djkabutar sorry for the confusion earlier with the extra commits. Should be clean now — let me know if anything else needs fixing.