Skip to content

fix(vidstack): type legacy vite plugin - #1801

Merged
mihar-22 merged 1 commit into
mainfrom
fix/1792-vite-enforce-type
May 25, 2026
Merged

fix(vidstack): type legacy vite plugin#1801
mihar-22 merged 1 commit into
mainfrom
fix/1792-vite-enforce-type

Conversation

@mihar-22

Copy link
Copy Markdown
Member

Summary

  • Type the legacy Vite plugin helper as Vite's Plugin type.
  • Keeps the enforce: 'pre' value checked against Vite's plugin contract.

Fixes #1792

Validation

  • pnpm install --frozen-lockfile succeeded in the isolated fix/1792-vite-enforce-type worktree.
  • pnpm exec tsgo -p tsconfig.json --noEmit failed at the repository root with exit code 2 and 1035 diagnostic lines. The failures are broad existing root tsconfig issues: React TSX files are checked without jsx, Vitest globals are missing for test files, and packages/vidstack/tsdown.config.ts cannot find rolldown types. No diagnostics matched packages/vidstack/vite.config.ts, legacyPlugin, or enforce.
  • cd packages/vidstack && pnpm exec tsgo -p tsconfig.json --noEmit passed.

@mihar-22 mihar-22 changed the title fix: type legacy vite plugin fix(vidstack): type legacy vite plugin May 25, 2026
@mihar-22
mihar-22 marked this pull request as ready for review May 25, 2026 04:55
@mihar-22
mihar-22 merged commit 275dbd7 into main May 25, 2026
1 check passed
@mihar-22
mihar-22 deleted the fix/1792-vite-enforce-type branch May 25, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Vite config plugin enforce type mismatch

1 participant