Skip to content

fix(vidstack): ignore scroll movement for touch gestures #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihar-22 merged 1 commit into from
May 26, 2026
Merged

fix(vidstack): ignore scroll movement for touch gestures #1819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions packages/vidstack/src/components/ui/gesture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ import {
import { useMediaContext, type MediaContext } from '../../core/api/media-context';
import { isTouchPinchEvent } from '../../utils/dom';

interface TouchPoint {
x: number;
y: number;
}

/**
* This component enables actions to be performed on the media based on user gestures.
*
Expand All @@ -25,6 +30,7 @@ export class Gesture extends Component<GestureProps, {}, GestureEvents> {

#media!: MediaContext;
#provider: HTMLElement | null = null;
#touchStart: TouchPoint | null = null;

protected override onSetup(): void {
this.#media = useMediaContext();
Expand Down Expand Up @@ -60,6 +66,11 @@ export class Gesture extends Component<GestureProps, {}, GestureEvents> {
if (eventType === 'pointerup' || eventType === 'pointerdown') {
const pointer = this.#media.$state.pointer();
if (pointer === 'coarse') {
if (eventType === 'pointerup') {
listenEvent(this.#provider, 'touchstart', this.#onTouchStart.bind(this), {
passive: true,
});
}
eventType = eventType === 'pointerup' ? 'touchend' : 'touchstart';
}
}
Expand All @@ -80,6 +91,7 @@ export class Gesture extends Component<GestureProps, {}, GestureEvents> {
this.$props.disabled() ||
(isPointerEvent(event) && (event.button !== 0 || this.#media.activeMenu)) ||
(isTouchEvent(event) && this.#media.activeMenu) ||
this.#isTouchScroll(event) ||
isTouchPinchEvent(event) ||
!this.#inBounds(event)
) {
Expand Down Expand Up @@ -115,6 +127,29 @@ export class Gesture extends Component<GestureProps, {}, GestureEvents> {
this.#presses++;
}

#onTouchStart(event: TouchEvent) {
if (isTouchPinchEvent(event)) {
this.#touchStart = null;
return;
}

const touch = event.changedTouches[0] ?? event.touches[0];
this.#touchStart = touch ? { x: touch.clientX, y: touch.clientY } : null;
}

#isTouchScroll(event: Event) {
if (!isTouchEvent(event) || event.type !== 'touchend') return false;

const touch = event.changedTouches[0] ?? event.touches[0],
start = this.#touchStart;

this.#touchStart = null;

if (!touch || !start) return false;

return Math.abs(touch.clientX - start.x) > 10 || Math.abs(touch.clientY - start.y) > 10;
}

#handleEvent(event: Event) {
this.el!.setAttribute('data-triggered', '');
requestAnimationFrame(() => {
Expand Down
Loading