Skip to content

fix(vidstack): preserve default layout classes in Svelte #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihar-22 merged 1 commit into from
May 26, 2026
Merged

fix(vidstack): preserve default layout classes in Svelte #1828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/vidstack/src/elements/define/layouts/default/audio-layout-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,13 @@ export class MediaAudioLayoutElement

this.#media = useMediaContext();

this.classList.add('vds-audio-layout');
this.#addLayoutClass();

this.#setupWatchScrubbing();
}

protected onConnect() {
this.#addLayoutClass();
setLayoutName('audio', () => this.isMatch);
this.#setupMenuContainer();
}
Expand All @@ -66,6 +67,10 @@ export class MediaAudioLayoutElement
return this.isMatch ? Layout() : null;
}

#addLayoutClass() {
this.classList.add('vds-audio-layout');
}

#setupMenuContainer() {
const { menuPortal } = useDefaultLayoutContext();

Expand Down
7 changes: 6 additions & 1 deletion packages/vidstack/src/elements/define/layouts/default/video-layout-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,11 @@ export class MediaVideoLayoutElement

this.#media = useMediaContext();

this.classList.add('vds-video-layout');
this.#addLayoutClass();
}

protected onConnect() {
this.#addLayoutClass();
setLayoutName('video', () => this.isMatch);
this.#setupMenuContainer();
}
Expand All @@ -62,6 +63,10 @@ export class MediaVideoLayoutElement
return $signal(this.#render.bind(this));
}

#addLayoutClass() {
this.classList.add('vds-video-layout');
}

#setupMenuContainer() {
const { menuPortal } = useDefaultLayoutContext();

Expand Down
Loading