HNSW Index: DDL Test#28
Open
villagedeb wants to merge 1 commit into
Open
Conversation
Also adds a sanity check for the number of root pages.
villagedeb
added a commit
to villagesql/villagesql-server
that referenced
this pull request
Jul 17, 2026
1. Skip Custom_index::load() during the index creation path. 2. Restore the storage reference in the custom column and custom index storage contexts. Although the storage reference is normally needed only during loading, the InnoDB index creation path reads it from the storage context and persists it in the data dictionary. For previously loaded custom columns and indexes, the storage context no longer contains this value, causing the data dictionary entry to be overwritten with 0. As a result, the storage reference is lost after restart. Part of #386 Tested by villagesql/vsql-vector#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds a sanity check for the number of root pages.