Remove tabs permission#4
Open
andrei14vl wants to merge 2 commits into
Open
Conversation
…re the completion tab id. This way we don't need to iterate (and read) through all tabs anymore to find it.
Author
|
@vintageplayer please let me know if this makes sense. Thank you for putting the effort to rewrite this essential extension in the first place! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'tabs' permission can be removed if we store the completion tab id at creation. This way we don't need to iterate (and read) through all tabs anymore to find it.
Without requiring the
tabspermission users would not get the access request toRead your browsing historywhen installing the extension, making it less worrisome in terms of privacy.