Debugger records all old heaps and their parent heaps - #973
Open
jackstodart wants to merge 34 commits into
Open
Conversation
…eaps in Executor, Evaluator
marcoeilers
reviewed
May 8, 2026
…sume heaps, not all checked yet
…nhale, unfolding etc
# Conflicts: # src/main/scala/rules/Evaluator.scala
jackstodart
marked this pull request as draft
May 27, 2026 21:23
…rding in CurrentPerm, record intermediate heaps for functions
jackstodart
marked this pull request as ready for review
May 29, 2026 19:19
…class; but some heaps still not recorded during consolidation
# Conflicts: # src/main/scala/rules/Consumer.scala # src/main/scala/rules/Evaluator.scala # src/main/scala/rules/Executor.scala # src/main/scala/rules/MagicWandSupporter.scala
jackstodart
marked this pull request as draft
July 21, 2026 14:39
jackstodart
marked this pull request as ready for review
July 21, 2026 16:40
AndreaKe
reviewed
Jul 31, 2026
AndreaKe
left a comment
AndreaKe
left a comment
Collaborator
There was a problem hiding this comment.
I left some comments. Otherwise, LGTM.
| ) | ||
| val temporaryHeapRecord3 = (temporaryHeapRecord1, temporaryHeapRecord2) match { | ||
| case (Some((label1, cause1, pcs1, heaps1)), Some((label2, cause2, _, heaps2))) => | ||
| if (label1 == label2 && cause1 == cause2) Some(label1, cause1, pcs1, heaps1 ++ heaps2) else None |
Collaborator
There was a problem hiding this comment.
Is having different labels/causes something that can actually happen? Or does it indicate that something is wrong?
Author
There was a problem hiding this comment.
This should not actually happen but I didn't want to cause crashes here if the debugger records heaps incorrectly. Added logger warning in this case. It would be very finicky to record the children heaps because I would have to put this condition inside the new debugOldHeaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the debugger from recording only heaps referenced in assumptions, to recording all heaps when they are created. Also records the statement or expression that caused the heap to be created, and any possible branch conditions.
Debugger now prints the parents and causes when printOldHeaps is on; it's a little verbose maybe, but it's off by default anyway.