Skip to content

Add From implementation to Certificate when cert_nossl #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BRA1L0R wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −1
Open

Add From implementation to Certificate when cert_nossl #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0efc6b
Implement from and into x509_cert::Certificate for Certificate type w…
BRA1L0R Nov 13, 2025
5d10b11
remove unnecessary cert method exposing internal functionality
BRA1L0R Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/target
.vscode/
.vscode/
.zed/
Copy link
Copy Markdown
Member

@tylerfanelli tylerfanelli May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Copy Markdown
Contributor

@larrydewey larrydewey May 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zed is an editor like VSCode. This is to make sure those settings are synced into the repository

12 changes: 12 additions & 0 deletions src/certs/snp/cert_nossl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,15 @@ impl Certificate {
fn io_error_other<S: Into<String>>(error: S) -> io::Error {
io::Error::new(ErrorKind::Other, error.into())
}

impl From<x509_cert::Certificate> for Certificate {
fn from(value: x509_cert::Certificate) -> Self {
Self(value)
}
}

impl From<Certificate> for x509_cert::Certificate {
fn from(Certificate(cert): Certificate) -> Self {
cert
}
}
Loading