feat(layers) Port SolidPolygonLayer to WebGPU#10142
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial WIP port of SolidPolygonLayer
extrusions are not working.
Summary
This PR ports
SolidPolygonLayerto WGSL/WebGPU and updates the GeoJSON polygons example so it can be exercised from the website’s device tabs.Changes
SolidPolygonLayer WebGPU support
SolidPolygonLayer.SolidPolygonLayerto provide WGSL shader source on WebGPU while keeping the existing GLSL path for WebGL.solidPolygon.Core WebGPU plumbing fixes
Example updates
Files changed
modules/layers/src/solid-polygon-layer/solid-polygon-layer.wgsl.tsmodules/layers/src/solid-polygon-layer/solid-polygon-layer.tsmodules/layers/src/solid-polygon-layer/solid-polygon-layer-uniforms.tsmodules/core/src/lib/attribute/attribute.tsmodules/core/src/lib/attribute/data-column.tsmodules/core/src/lib/attribute/attribute-manager.tsmodules/core/src/lib/layer.tsmodules/core/src/effects/lighting/lighting-effect.tsexamples/website/geojson/app.tsxwebsite/src/examples/geojson-layer-polygons.jsexamples/website/globe/app.tsxwebsite/src/examples/globe-view.jsexamples/website/trips/app.tsxwebsite/src/examples/trips-layer.jsexamples/playground/vite.config.jsValidation
./node_modules/.bin/tsc -p modules/layers/tsconfig.json --noEmit./node_modules/.bin/vitest run --project render test/render/test-cases/geojson-layer.spec.tsnpm run build-bundle --prefix modules/layersNotes
Layerdraw-state change.