♻️ Move the CLI to the current review system - #349
Merged
Conversation
Resolve review scope from the server, preserve annotations atomically, honor review versions and command idempotency, and retire raw API access to the old SDK mutations.
Delete hotspot and confirmed-region cache APIs, persistence, automatic pass logic, context projections, and reporter controls. Stale cache data can no longer affect comparison results or local review output.
Emit the canonical visual_review contract across commands, upload results, local context, types, tests, and JSON documentation. Remove status fallbacks that kept the retired review response shape alive.
Keep the local baseline reporter on its own review state vocabulary and delete obsolete tests that only described retired cache inputs. The retained context workflow still proves stale cache files cannot affect evidence.
Use direct names like review state, analysis details, and status response throughout the CLI. Remove inflated compatibility terminology from code, tests, and repo-owned docs.
Keep the current output contract tests focused on supported review data instead of preserving retired field names as negative fixtures.
Require the current status and context response shapes, remove flat and cached v1 adapters, and use plain local formatting names.
Run the real CLI process against a stateful HTTP boundary to prove decisions, annotations, stale-version errors, auth refresh, and idempotent retries.
Keep the shipped Vizzly skill aligned with the current review and diff behavior after removing hotspot and confirmed-region support.
Submit comparison decisions directly after resolving their build and organization. Keep command IDs for safe auth retries without fetching or sending a review counter.
Robdel12
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The server is removing the original review system, so the CLI cannot keep calling its endpoints or translating its data. The old code mixed current review state with approval fields, response fallbacks, screenshot-level decisions, flaky markers, hot spots, dynamic regions, and local TDD caches. That made CLI output depend on behavior the product no longer supports.
Approach
Keep the review commands, but run them through the current review API. Approve and reject resolve the comparison's build and organization, then send a command ID, decision, and optional annotation. Comment continues to use the build comment API. Stable command IDs keep token-refresh retries safe without fetching or sending review counters.
Builds, comparisons, status, context, upload results, the local TDD dashboard, and visual context consume the current server responses directly. The old approval fields, adapters, hot-spot and dynamic-region calculations, metadata, caches, and overlays are deleted rather than translated.
The only removed command-line option is
context screenshot --window-size, because it controlled the deleted hot-spot history window. Approve, reject, comment, status, context, run, upload, and TDD remain.Evidence
Real CLI process coverage exercises approve, reject, annotations, token refresh, same-command retries, and another decision after review state changes. The review, context, status, API, TDD, and output suites pass against the current response contract.
Deployment note
This is the CLI half of vizzly-testing/vizzly#707. Deploy Vizzly first because this branch consumes the server's new
review_locatorresponse; deploy the CLI after the Vizzly server and workers are live.