Skip to content

Fix xclid again. Fixes #312#313

Merged
vladkens merged 1 commit into
vladkens:mainfrom
Flaburgan:312-fix-scraping
Jun 15, 2026
Merged

Fix xclid again. Fixes #312#313
vladkens merged 1 commit into
vladkens:mainfrom
Flaburgan:312-fix-scraping

Conversation

@Flaburgan

Copy link
Copy Markdown
Contributor

No description provided.

@JAAVAAD

JAAVAAD commented Jun 12, 2026

Copy link
Copy Markdown

I ran the modified code part #313. The code works perfectly. Please update the library as soon as possible.
Thank you.

vladkens

@HelmaLog

Copy link
Copy Markdown

that was cool

NielsOerbaek added a commit to NielsOerbaek/twscrape that referenced this pull request Jun 14, 2026
Port the fix from vladkens#313 to this fork's structure.

X migrated from the webpack build to a Vite "x-web" build:
- Script bundles are now linked directly in the page HTML under
  https://.../x-web/*.js, so get_scripts_list collects those (deduped)
  and falls back to the legacy webpack marker logic.
- The animation-indices file moved from ondemand.s.*.js (linked directly)
  to sign.o-*.js, which is dynamically imported from a bundle chunk.
  _find_indices_url scans chunks concurrently and resolves the first
  sign.o reference via urljoin.

INDICES_FILE_RE matches both ondemand.s and sign.o with a \b guard to
avoid substring hits like design.o. parse_anim_idx keeps the legacy
ondemand.s name-map fast path and threads an optional client through.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vladkens vladkens merged commit ef43d73 into vladkens:main Jun 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants