Conversation
…o use original packedPFCandidates collection in miniAODFromMiniAOD_customizeCommon()
testing of perFill O2O Energy 0 check dont upload empty payklod to empty tags in duringfill mode of perFill O2O extract findFillToProcess from populateIovs in perFill O2O simple catch2 test of LHCInfoPerFill PopCon test: LHCInfoPerFillPopConSourceHandler.isPayloadValid works test: addPayloadToBuffer works refactor getLumiData, add inclusiveSearchTime arg to findFillToProcess catch2 tests code-format remove dead code: add empty payload in duringfill adjust expected value in test_lhcInfoNewPopCon.sh for perFill duringFill mode extract createSubsystemDbSessions from populateIovs refactor: extract getNextFillSearchTimestamp from populateIovs refactor: extract handleIfNewTagAndGetLastSince and fetchLastPayload from populateIovs add TestLHCInfoPerFillPopConSourceHandler with mocks Successfull populateIovs test mock execution time, successful duringFill test print additional info on invalid energy, rename throwIfInvalidPayload throw exc or filter out invalid payloads depending on throwOnInvalid in LHCInfoPer O2O duringFill mode
…ith cms-merge-topic
…n of Module label, cpptype and Record name.
and replaced string-based keys with UniqueKey in AllocMonitorCircles.py.
…reFWLite [FWCore] Fix segmentation fault in testRefInROOT::testGoodChain when using TChain
cmsDriver.py "command line options" readiness for copy-paste
…ators [NGT] Template LayerClusters associators to support both CaloCluster and PFCluster collections
[Hotfix] MET Validation: Division by zero
…_0_X Introduce new dEdX weights V19 HGCAL Geometry
…nitorCircles PerfTools/AllocMonitor: Update edmModuleAllocJsonToCircles.py to add "event setup" transition for ESProducers
Review: Allow defining valid range of Energy values for LHCInfoPerFill O2O
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
making the MR to myself to help integration with @nurfikri89