Skip os.makedirs for GCS profile paths in TPU worker#2982
Open
subhamsoni-google wants to merge 4 commits into
Open
Skip os.makedirs for GCS profile paths in TPU worker#2982subhamsoni-google wants to merge 4 commits into
subhamsoni-google wants to merge 4 commits into
Conversation
The C++ profiler backend (tsl::Env) natively supports gs:// paths via RetryingGcsFileSystem, handling directory creation internally. Guard the os.makedirs call to only run for local filesystem paths, preventing it from creating a spurious local directory named "gs:/bucket/..." when a GCS URI is passed as torch_profiler_dir. Add tests verifying: - GCS paths skip os.makedirs on rank 0 (single PP) - GCS paths skip os.makedirs in pipeline-parallel mode - Local paths still call os.makedirs in pipeline-parallel mode - GCS paths are passed directly to jax.profiler.start_trace
Author
|
I have verified over GKE env, that the vllm via the logdir is working perfectly fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ profiler backend (tsl::Env) natively supports gs:// paths via RetryingGcsFileSystem, handling directory creation internally. Guard the os.makedirs call to only run for local filesystem paths, preventing it from creating a spurious local directory named "gs:/bucket/..." when a GCS URI is passed as torch_profiler_dir.
Add tests verifying:
Description
Start with a short description of what the PR does and how this is a change from
the past.
The rest of the description includes relevant details and context, examples:
If the change fixes a Github issue, please include a link, e.g.,:
FIXES: #123456
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure: