-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
[WideEP] Update DeepEP version in Dockerfile #45321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tlrmchlsmth
wants to merge
30
commits into
main
Choose a base branch
from
fix/deepep-commit-hash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
71604cb
[WideEP] Update DeepEP version and pin NCCL >= 2.30.4
tlrmchlsmth 1152444
Move NCCL install from base stage to extensions-build stage
tlrmchlsmth 2763c72
Use pip-installed NCCL for DeepEPv2 GIN device headers
tlrmchlsmth 1783ac7
Pin NCCL to 2.30.7 and guard against CUDA 12
tlrmchlsmth 72ab9d7
Use pip for all NCCL installs, drop apt libnccl-dev
tlrmchlsmth 2d16eab
Re-upgrade NCCL in test stage after dev requirements
tlrmchlsmth 54f604a
Use UV_OVERRIDE to pin NCCL instead of separate re-upgrade lines
tlrmchlsmth 9892bce
Document NCCL override for non-Docker DeepEPv2 installs
tlrmchlsmth 11feadc
Fix NCCL allocator link failure with pip-only NCCL
tlrmchlsmth 58859ae
Guard against DeepEPv2 SIGSEGV when NCCL GIN is unavailable
tlrmchlsmth 1e9e837
Merge branch 'main' into fix/deepep-commit-hash
tlrmchlsmth 7d6c8bc
Fix GIN skip crashing in spawned subprocess
tlrmchlsmth a8fa73f
Add NCCL GIN diagnostics to B200 fused MOE CI step
tlrmchlsmth 4bc4ecf
Fix ruff formatting for GINNotAvailableError raise
tlrmchlsmth 519c554
Merge branch 'main' into fix/deepep-commit-hash
tlrmchlsmth cc6712f
Merge branch 'main' into fix/deepep-commit-hash
tlrmchlsmth 40e191a
Fix GIN check: treat query failure as GIN-unavailable
tlrmchlsmth 97dbca7
Apply ruff formatting fixes
tlrmchlsmth 5d469f4
Create libnccl.so linker symlink from pip-installed NCCL
tlrmchlsmth 441a522
Link nccl_allocator against libnccl.so.2 directly
tlrmchlsmth 27121dd
Skip test_deepep_v2_manager_lifecycle when GIN is unavailable
tlrmchlsmth 20b07f6
Address review comments
tlrmchlsmth f975515
Merge branch 'main' into fix/deepep-commit-hash
tlrmchlsmth a6ab383
Initialize ncclCommProperties with required header fields
tlrmchlsmth 0f698a0
Fix GIN check: defer when NCCL comm not yet initialized
tlrmchlsmth b289f00
Merge branch 'main' into fix/deepep-commit-hash
tlrmchlsmth d7012ac
Fix NCCL downgrade from bare pip install in CI
tlrmchlsmth 99e5ea6
Merge branch 'main' into fix/deepep-commit-hash
tlrmchlsmth 54bcda0
[CI] Use pip --no-deps for tensorizer to fix AMD CI
tlrmchlsmth 4f04dd6
Merge branch 'main' into fix/deepep-commit-hash
tlrmchlsmth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NCCL symm mem allocator JIT-compiles a C++ extension that links with
-lnccl. Previously the aptlibnccl-devpackage placedlibnccl.soin/usr/libwhere the system linker could find it. With pip-only NCCL, the.sois insite-packages/nvidia/nccl/lib/— invisible told.This adds
find_nccl_library_paths()to discover the pip package's lib dir and passes-L<path>to the linker, fixing thecannot find -lncclerror without needing apt.— via claude