-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
[Core] Release NCCL communicator memory in sleep mode #46234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aoshen02
wants to merge
9
commits into
vllm-project:main
Choose a base branch
from
aoshen02:nccl-comm-offload-sleep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e9dd1db
[Core] Release NCCL communicator memory in sleep mode
aoshen02 0dc82d9
Merge branch 'main' into nccl-comm-offload-sleep
aoshen02 cfd92a1
Merge branch 'main' into nccl-comm-offload-sleep
aoshen02 919adc4
Merge branch 'main' into nccl-comm-offload-sleep
aoshen02 3cc12e7
[Core] Log freed/allocated direction for NCCL suspend/resume
aoshen02 78f5b0e
Merge branch 'main' into nccl-comm-offload-sleep
aoshen02 b27115f
[Core] Generalize sleep comm release to a device-communicator surface
aoshen02 a3444d1
Update base_device_communicator.py
aoshen02 ad16cec
Update pynccl_wrapper.py
aoshen02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we actually have some ongoing work that will allow flashinfer's comms to be suspended as well (see flashinfer-ai/flashinfer#3727), (flashinfer-ai/flashinfer#3745). Could we have a more generic
suspend/resumesurface indevice_communicators, that each communicator can override?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done