Reentrant library#31
Open
TheCount wants to merge 47 commits into
Open
Conversation
hashtab.cpp: do not use yaep_free() on memory obtained with operator new().
Required for vnmakarov#12.
Hack for vnmakarov#12 while using the current API.
As a test, eliminate the static global variable anode_cost. Required for vnmakarov#12.
Eliminate all global variables not needed in sread_terminal() or sread_rule(). Required for vnmakarov#12.
Eliminate remaining global variables used by sread_terminal() and sread_rule() by passing parser data via reentrancy hack. Required for vnmakarov#12.
Make sgramm.y compatible with older bison versions.
Extend hack introduced in a57380f for vnmakarov#12.
Required for vnmakarov#12.
Required for vnmakarov#12.
Required for vnmakarov#12.
Hide debug variables n_parse_term_nodes, n_parse_abstract_nodes, and n_parse_alt_nodes when NO_YAEP_DEBUG_PRINT is defined.
Required for vnmakarov#12.
Required for vnmakarov#12.
Required for vnmakarov#12.
Avoids warnings in C and errors in C++.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should make the YAEP library mostly reentrant without changing the public API. I haven't fixed the following three things:
syntax_error,parse_alloc, andparse_free. The other callbacks can receive such a pointer somewhat awkwardly, viastruct _yaep_reentrant_hack. Changing this would require changing the public API.read_rulehas static local variables. But this function is only used for tests, so it should be OK.all_searchesandall_collisionsremain. In single-threaded usage, they'll work as intended. In multi-threaded usage, concurrent access is technically undefined behavior, though practically, the worst that can happen is that their value is trashed. Since these variables are used for debugging purposes only, they should not affect the behavior of the library per se.This PR supersedes #21.