feat: add optional Milvus vector backend - #373
Open
zc277584121 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Milvus as an opt-in vector storage backend while keeping ChromaDB as the default.
The backend uses
pymilvus.MilvusClientwith a shareduriand optionaltokenconfiguration for Milvus Lite, remote Milvus servers, and Zilliz Cloud. It preserves MineContext's per-context-type collections and todo deduplication lifecycle, uses explicit schemas with COSINEAUTOINDEX, and reconstructs completeProcessedContextrecords with optional vectors.Additional behavior includes:
pymilvus[milvus-lite]dependency metadata;This is backward compatible and does not change the default storage configuration.
Tests
PYTHONPATH=. uv run --no-project --python 3.11 --with pytest --with pydantic --with loguru --with pyyaml --with 'pymilvus[milvus-lite]>=3.0.0' pytest tests/test_milvus_backend.py -q—6 passeduvx pre-commit run black --files ...— passeduvx pre-commit run isort --files ...— passeduvx ruff check --select E9,F63,F7,F82 ...— passeduv lock --check— resolved successfully