fix(benchmark): account for failed evaluations - #3719
Draft
ehz0ah wants to merge 1 commit into
Draft
Conversation
Persist failed LoCoMo rows, report expected-denominator accuracy, separate successful load metrics, and add optional benchmark exit gates.
ehz0ah
force-pushed
the
fix/benchmark-result-integrity
branch
from
August 4, 2026 02:44
edeb4ee to
44db4e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make OpenViking benchmark results failure-inclusive and suitable for opt-in CI gating.
LoCoMo worker failures now persist explicit failed rows and the runner verifies planned versus recorded identities/counts. Judge/stat output separates expected, failed, ungraded, correct, and wrong rows and reports both graded-only and expected-denominator accuracy.
The session contention benchmark now calculates each adapter/operation overall QPS from its own active span, reports successful QPS, separates successful and failed latency, and offers default-off failure-rate and successful-p95 exit gates.
Human Involvement
Related Issue
Found during a source-first benchmark audit; no existing issue or open PR covered the denominator and aggregation defects together.
Type of Change
Changes Made
completed/failedstatus and errors for every planned QA row.--max-failure-rate-percentand--max-success-p95-msgates.Testing
Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
The new contention SLO gates are disabled by default, preserving existing command exit behavior unless thresholds are explicitly supplied. No live server load run was used as proof; deterministic tests cover persistence, denominator, aggregation, and exit-gate semantics.