fix(ovpack): restore protected scope roots - #3889
Open
Oldrich333 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the full-backup overwrite restore path for initialized servers by treating protected namespace roots as structural containers:
viking://user/viking://agentinstead of deleting the protected root;viking://resources.Closes #3875.
This supersedes the approach in the closed #3876: clearing children alone still leaves restore failing when archive extraction calls
mkdir("viking://user")(PERMISSION_DENIED). This change covers both phases.Type of Change
Testing
ruff checkpasses for changed files.ruff format --checkpasses for changed files.tests/misc/test_ovpack_import_policy.pypass.resourcesand protecteduserroots./api/v1/resources/temp_upload, restored through/api/v1/pack/restorewithon_conflict=overwrite, and read the restored resource tree. The isolated container and data were removed afterward.Safety properties
Related Issues