fix(privacy): avoid replacing bare values in prose - #3905
Open
ranxi2001 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent skill privacy placeholderization from rewriting configured bare values
that merely appear at the start of ordinary prose after a colon or equals sign.
Bare assignments now match only when the configured value is followed by
optional horizontal whitespace and then LF, CRLF, or end of input. Quoted-value
replacement behavior and the placeholder format remain unchanged.
Human Involvement
Related Issue
Fixes #3791
Type of Change
Changes Made
Testing
Commands run:
Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
The focused helper tests report 5 passed with four pre-existing Pydantic
deprecation warnings. The complete privacy service module was attempted, but
service-level cases require the unavailable
ragfs_pythonnative binding andone existing extraction case invokes configured VLM I/O.
make check-depsstops because CMake is absent on this host. No native code is changed by this PR.