fix(memory): resolve assistant-only event ranges - #3951
Open
mengcody wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Event write targets are derived from user-role messages inside each extracted range. Ranges that contain only assistant/tool activity therefore produce no target URI, even when the session has exactly one unambiguous user-owned target, and are later skipped with
Missing resolved URI.Tests
PYTHONPATH=. .venv/bin/python -m pytest tests/session/memory/test_memory_isolation_handler.py -q --no-cov(34 passed)PYTHONPATH=. .venv/bin/python -m pytest tests/session/memory/test_memory_updater.py -q --no-cov -k 'unresolved or missing_resolved'(2 passed)uvx ruff check openviking/session/memory/memory_isolation_handler.py tests/session/memory/test_memory_isolation_handler.pyuvx ruff format --check openviking/session/memory/memory_isolation_handler.py tests/session/memory/test_memory_isolation_handler.pyThe full
test_memory_updater.pycurrently has 6 unrelated failures onmainbecause existing test fakes/mocks do not accept the newly addedlease_refargument.