Skip to content

Merge gh-pages branch - #3

Open
ZiglioUK wants to merge 18 commits into
volpino:gh-pagesfrom
ZiglioUK:gh-pages
Open

Merge gh-pages branch#3
ZiglioUK wants to merge 18 commits into
volpino:gh-pagesfrom
ZiglioUK:gh-pages

Conversation

@ZiglioUK

@ZiglioUK ZiglioUK commented Dec 7, 2011

Copy link
Copy Markdown
Contributor

Maybe we could remove the master branch and keep just gh-pages, what do you think?

volpino and others added 17 commits August 9, 2011 15:43
1. The display layer is only created once (needed for my Google Earth
API library)
2. The format is created before creating timeline, because I need to
pass some options to the kml layer for using Google Maps' Spherical
Mercatore
3. Added some additional properties for remembering and displaying the
first feature and storing the latest date as current
4. Fixed a problem with popups, since the feature are destroyed when
after sliding the timebar, that would leak and make impossible to close
the popups.

Added kml layer with my patch to set the timestamp on placemarks
current_date, setting it to undefined internally in KML.js when calling
read(), so we can work out the latest date
Added KML format, plus other changes
@volpino

volpino commented Dec 11, 2011

Copy link
Copy Markdown
Owner

I'd like to fix the bugs we're discussing before merge to gh-pages so we release a stable demo and not a bleeding edge one. Do you agree?

@ZiglioUK

Copy link
Copy Markdown
Contributor Author

That's fine with me, I didn't have clear what the roles of 'gh-pages' and 'master' should be.
Also I didn't realize I had a small error:
timeline.js:249 Uncaught ReferenceError: past_seconds is not defined

  1. Not too sure in javascript what it does declaring a variable at the begin of a function followed by comma. I thought perhaps it would declare a variable with var scope but that doesn't seem to work
  2. Have never really understood what this piece of code is for:
    if (past_seconds - firstdate > 0) {
    $(this.slider).slider("value", Math.ceil(((past_seconds - firstdate) /
    (this.current_date - firstdate)) * 100));
    }

@ZiglioUK

Copy link
Copy Markdown
Contributor Author

Oh, I see you've already fixed the error at line 249! cheers

The code:
if (typeof console == "undefined" || typeof console.log == "undefined") console = { log: function() {} };

was there because I noticed the object console wasn't available on all browsers

@volpino

volpino commented Dec 11, 2011

Copy link
Copy Markdown
Owner

gh-pages branch is published on http://volpino.github.com/openlayers-timeline/

I removed all the console.log because they are only for personal debugging and should not be in the repo.

That piece of code actually i think it's not used already but it's useful if there's the need to start the slider from an arbitrary date. for example: http://sonetlab.fbk.eu/wikitrip/#|en|James%20K.%20Polk|1178192008|1 (i wrote all this code for that project and then i extracted a more general library that should be included in that project too)

@ZiglioUK

Copy link
Copy Markdown
Contributor Author

Very impressive work! I see you set the timeline from a date past the beginning.

Another project I've been working on (but not for a while) has been making the Google Earth plugin work with OpenLayers:
https://github.com/ZiglioNZ/GoogleEarth-for-OpenLayers/blob/master/GoogleEarth-for-OpenLayers/src/googleearthforol.js

I need to fix it to make it work with the cluster strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants