Skip to content

fix: update border-radius tokens per new radius guidelines #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcelovicentegc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: update border-radius tokens per new radius guidelines #2130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7150626
fix(popover): update border-radius from radius-2 to radius-3
marcelovicentegc Feb 18, 2026
358db69
fix: update border-radius tokens for tooltip, toast, alert, and docs
marcelovicentegc Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/docs/pages/foundations/radius/best-practices.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ The radius used in a element is related to its size and placement.
| Token | Usage |
| :------------- | :---------------------------------------------------------------------------------------- |
| `$radius-0` | Page components (Header and Content) and Admin Navigation components (Topbar and Sidebar) |
| `$radius-1` | Checkboxes and Buttons inside inputs |
| `$radius-2` | Buttons, Inputs, Filters, Alerts, Toasts, Cards, and Popovers |
| `$radius-3` | Modals |
| `$radius-1` | Checkboxes, Buttons inside inputs, and Tooltips |
| `$radius-2` | Buttons, Inputs, and Filters |
| `$radius-3` | Modals, Alerts, Toasts, Cards, and Popovers |
| `$radius-full` | Tags and Avatars |
2 changes: 1 addition & 1 deletion packages/shoreline/src/themes/sunrise/components/alert.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
justify-content: flex-start;
padding: var(--sl-space-4) var(--sl-space-3) var(--sl-space-4)
var(--sl-space-5);
border-radius: var(--sl-radius-2);
border-radius: var(--sl-radius-3);

& [data-sl-alert-icon-container] {
flex-shrink: 0;
Expand Down
2 changes: 1 addition & 1 deletion packages/shoreline/src/themes/sunrise/components/popover.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
background: var(--sl-bg-base);
border: var(--sl-border-base);
box-shadow: var(--sl-shadow-1);
border-radius: var(--sl-radius-2);
border-radius: var(--sl-radius-3);
z-index: var(--sl-z-6);
/* ideally we should be using Content to handle the padding */
/* but Container/Content don't seem to work in this case as documented on https://github.com/vtex/shoreline/issues/1338 */
Expand Down
2 changes: 1 addition & 1 deletion packages/shoreline/src/themes/sunrise/components/toast.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
font: var(--sl-text-emphasis-font);
padding: var(--sl-space-4) var(--sl-space-5);
width: 22.5rem;
border-radius: var(--sl-radius-2);
border-radius: var(--sl-radius-3);
box-shadow: var(--sl-shadow-2);

& [data-sl-toast-icon-container] {
Expand Down
2 changes: 1 addition & 1 deletion packages/shoreline/src/themes/sunrise/components/tooltip-popover.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
font: var(--sl-text-caption-1-font);
letter-spacing: var(--sl-text-caption-1-letter-spacing);
max-width: var(--sl-tooltip-popover-max-width);
border-radius: var(--sl-radius-2);
border-radius: var(--sl-radius-1);
padding: var(--sl-space-2) var(--sl-space-3);
z-index: var(--sl-z-9);
border: var(--sl-border-base-strong);
Expand Down