Draft
Conversation
…uteDepth, resolveHeaders)
…dren - DataTableColumn.key widened from keyof T & string to string - DataTableColumn gains optional children property for nested columns - extractLeaves/resolveHeaders imported and re-exported from ./columns - createDataTable derives leaves (flat) from column tree; pipeline uses leaves - DataTableContext exposes leaves and headers (reactive 2D header grid) - DataTableAdapterContext.filterableKeys widened to readonly string[]
Wires together column layout, cell editing, row ordering, and row spanning on top of createDataTable with a ClientGridAdapter. Exports createDataGrid, createDataGridContext, and useDataGrid following the trinity pattern. Also fixes a pre-existing TypeScript error in spanning.ts (Array.from unknown type).
- Extract shared applyOrder helper, eliminating duplicate ordering logic between ClientGridAdapter and VirtualGridAdapter - Fix O(n*m) order.includes() → Set-based O(n) lookup in adapters and ordering.apply() - Simplify layout.ts columns computed to reuse pinned regions instead of double-computing resolved() - Fix editable column filter to match editing.ts guard - Remove unused RowSpanningOptions import and numbered comments - Clean up test mock imports
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createDataGridheadless composable extendingcreateDataTablewith column layout, cell editing, row reordering, row spanning, nested headers, and adapter-based virtualizationcreateDataTableto support recursive column definitions viachildren(aligning with Vuetify'sDataTableHeadershape)What's included
createDataTable refactor (prerequisite)
DataTableColumn.keyrelaxed fromkeyof T & stringtostringfor group column supportchildrenproperty for recursive nestingextractLeaves,computeDepth,resolveHeadersutilities incolumns.tsheadersandleavesexposed onDataTableContextcreateDataGrid composable
createDataGridContext,createDataGridPlugin,useDataGridTest plan