Skip to content

Merge in changes from upstream master (for better or worse).#1

Merged
MTCam merged 110 commits into
artificial_viscosityfrom
av-mrg-master
Feb 4, 2021
Merged

Merge in changes from upstream master (for better or worse).#1
MTCam merged 110 commits into
artificial_viscosityfrom
av-mrg-master

Conversation

@MTCam
Copy link
Copy Markdown
Collaborator

@MTCam MTCam commented Feb 3, 2021

No description provided.

MTCam and others added 30 commits September 2, 2020 10:39
@MTCam
Add adiabatic slip boundary implementation
75ade9d
@MTCam
Add total energy function to EOS
5f67847
@MTCam
Add make_pulse initialization utility
dc04dae
@MTCam
Add tests for and implementations of new init utilities
9699dd4
@MTCam
Fix some porting/compatibility issues
e07043d
@MTCam
Add pulse example
c1829c7
@MTCam
Fix up docs per CI/lint
d2c755e
@MTCam
Fix slip boundary expressions to avoid eye damage, make acoustic puls…
938666b 
…e example run faster
@MTCam
Merge branch 'master' into euler-slipwall-bc
8449135
@MTCam
Add AcousticPulse initializer that uses internal _make_pulse util
c053e35
@MTCam
Fix uniform flow init
0559972
@MTCam
Improve the slip wall docs a bit, clean up implementation, and a few …
c9884cd 
…other cosmetic changes.
@MTCam
Merge branch 'master' into euler-slipwall-bc
aa53fea
@MTCam
Merge branch 'master' into euler-slipwall-bc
7935119
@MTCam
Merge branch 'master' into euler-slipwall-bc
a758abe
@MTCam
Silence flake8 after pydocstyle merge
a471263
@MTCam
Fix examples flake8 errors - sigh
d5ed413
@MTCam
Merge branch 'master' into euler-slipwall-bc
6866f41
@MTCam
Make trivial change to test CI
fdbcd56
@MTCam
Merge branch 'master' into euler-slipwall-bc
1febbe5
@MTCam
Merge branch 'master' into euler-slipwall-bc
bfd0911
@MTCam
Add tests for slipwall
26cfeb9
@MTCam
Add test for slipwall flux
719fb10
@MTCam
Clean up the tests a bit.
558624c
@MTCam
Make trivial change to run CI again.
efd7612
@MTCam @inducer
Apply suggestions from code review
5d6e6cd 
Co-authored-by: Andreas Klöckner <inform@tiker.net>
@MTCam
Update per review comments
daaf7bb
@MTCam
Add comment per review request.
c0de30e
@MTCam
Respond to flake8 issues
fd6e60f
@MTCam
Respond to review comments
ceaa879
matthiasdiener and others added 18 commits December 7, 2020 18:04
@matthiasdiener
Avoid hwloc version conflicts by forcing pocl to load before mpi4py (i…
e3b12f3 
…llinois-ceesd#169)
@matthiasdiener
vortex-mpi: Don't run in 3D, fix warning (illinois-ceesd#171)
595f4af
@matthiasdiener @inducer
switch doc to furo theme (illinois-ceesd#172)
ad7f474 
* switch doc to furo theme

* fixes

* Add Github/releases links to TOC

Co-authored-by: Andreas Klöckner <inform@tiker.net>
@matthiasdiener
doc: split into separate files (illinois-ceesd#174)
7f8a796 
- Allows hierarchical content menu
- Reduces 'wall of text'
@matthiasdiener
support __version__ (illinois-ceesd#176)
31467cc
@matthiasdiener
profiling: don't carry kwargs around (illinois-ceesd#179)
c81cfab 
Fixes illinois-ceesd#177
@matthiasdiener
add example git commit hook to run flake8/pydocstyle (illinois-ceesd#181
3b62c5a 
)

* add example git hook to run flake8/pydocstyle

* cleanup flake8

* clarify location
@majosm @inducer
Add boundary conditions to diffusion operator (illinois-ceesd#156)
8d5d441 
* add boundary conditions to diffusion operator

* attempt to simplify diffusion_operator BC specification

* apply suggestions from review

* add more documentation for diffusion BCs

* add comment

* Update mirgecom/diffusion.py

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* make vectorized 'boundaries' a list instead of an object array

* update comment

Co-authored-by: Andreas Klöckner <inform@tiker.net>
@matthiasdiener
doc: clarify where condo env files can be reinstalled (illinois-ceesd…
28e07a4 
…#187)
@matthiasdiener
add pytato dependency (illinois-ceesd#160)
27f126b
@matthiasdiener
profiling: add pyopencl.Array elementwise kernels (illinois-ceesd#192)
d7e00ad 
Also adds totals for num_calls and time.

Mostly extracted from illinois-ceesd#96.
@matthiasdiener
doc: add documentation about PLATFORM_NOT_FOUND_KHR (illinois-ceesd#197)
af706ce
@matthiasdiener
CI fix (illinois-ceesd#200)
9feaa8d 
Fixes illinois-ceesd#199.
@matthiasdiener @inducer
add requirements_dev.txt file (illinois-ceesd#198)
7684074 
Co-authored-by: Andreas Klöckner <inform@tiker.net>
@matthiasdiener
batch script fixes (illinois-ceesd#194)
a018513
@majosm @inducer
Add variable diffusivity to diffusion_operator (illinois-ceesd#180)
a92e3a9 
* add variable diffusivity

* remove calls to deprecated flat_norm

* use quadrature discretization normal

* mention numerical flux formulation in docstring

* allow scalar values of alpha in diffusion_operator

* tweak docstring

* add comment about product rule decomposition

* cosmetic change

* add missing quad tag argument in obj array vectorize

* Apply suggestions from code review

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* make quad tag argument mandatory

* avoid promoting constant alpha to a DOFArray

* temporarilty change grudge branch

* Point grudge in requirements.txt back to master after majosm:project-constants

Co-authored-by: Andreas Klöckner <inform@tiker.net>
@majosm
Add leftover diffusion suggestions from illinois-ceesd#180 (illinois-…
ce4e022 
…ceesd#209)

* simplify alpha in heat-source-mpi example

* remove branch no longer needed after constant projection support added to grudge
@MTCam
Merge branch 'master' into av-mrg-master
7a9a81d
@MTCam MTCam requested a review from w-hagen February 3, 2021 20:06
@MTCam
Copy link
Copy Markdown
Collaborator Author

MTCam commented Feb 3, 2021

BTW, I think we need to ignore the CI failures atm, because they'll fail even on w-hagen/master.

@w-hagen
Copy link
Copy Markdown
Owner

w-hagen commented Feb 3, 2021

Looks like parts of the boundary conditions needed for my artificial viscosity routine got wiped out here. You beat me to this comment. While the usage exterior_sol and boundary_pair need to be reworked, if the goal is just to get this upstream master changes merged in here they probably could be left as is for the moment. They are on my list to fix in the mainline pull request

@MTCam
Copy link
Copy Markdown
Collaborator Author

MTCam commented Feb 3, 2021

Looks like parts of the boundary conditions needed for my artificial viscosity routine got wiped out here. You beat me to this comment. While the usage exterior_sol and boundary_pair need to be reworked, if the goal is just to get this upstream master changes merged in here they probably could be left as is for the moment. They are on my list to fix in the mainline pull request

Yeah, per our convo on Slack. I inadvertently removed these in the hand-merge. Any chance you could make sure your own tests work on this branch before we push something that breaks the hell out of it?

@w-hagen
Copy link
Copy Markdown
Owner

w-hagen commented Feb 3, 2021

I will pull this branch and make sure everything is running.

@w-hagen
Copy link
Copy Markdown
Owner

w-hagen commented Feb 4, 2021

Yeah, per our convo on Slack. I inadvertently removed these in the hand-merge. Any chance you could make sure your own tests work on this branch before we push something that breaks the hell out of it?

I will pull this branch and make sure everything is running.

Everything looks good after a few fixes to my boundary condition routines needed when updating to the latest packages.

@MTCam
Copy link
Copy Markdown
Collaborator Author

MTCam commented Feb 4, 2021

Everything looks good after a few fixes to my boundary condition routines needed when updating to the latest packages.

Terrific, ok to merge?

@w-hagen
Copy link
Copy Markdown
Owner

w-hagen commented Feb 4, 2021

Yeah, should be good.

@MTCam MTCam merged commit 37abb66 into artificial_viscosity Feb 4, 2021
@MTCam MTCam deleted the av-mrg-master branch February 4, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@w-hagen w-hagen Awaiting requested review from w-hagen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MTCam @w-hagen @majosm @inducer @matthiasdiener