Skip to content

Address review feedback for Entra Zod migration commands#17

Draft
Copilot wants to merge 2 commits into
waldekmastykarz/migrate-entra-commands-to-zodfrom
copilot/check-comments-and-resolve
Draft

Address review feedback for Entra Zod migration commands#17
Copilot wants to merge 2 commits into
waldekmastykarz/migrate-entra-commands-to-zodfrom
copilot/check-comments-and-resolve

Conversation

Copilot AI commented Jun 6, 2026

Copy link
Copy Markdown

Pull Request Title

Address review feedback for Entra Zod migration commands (approleassignment*, enterpriseapp*).

Linked Issue

Linked automatically by the system.

One PR = One Commit

This update focuses only on requested follow-ups from PR review comments and keeps the migration changes coherent and easy to review.

  • Schema/test alignment

    • Standardized spec schema acquisition to commandInfo.command.getSchemaToParse() as typeof options
    • Updated enterpriseapp-list.spec.ts to include schema-based validation coverage
    • Added missing invalid combination test in enterpriseapp-get.spec.ts (id + objectId)
  • Scopes parsing normalization

    • Updated approleassignment-add.ts and approleassignment-remove.ts to transform scopes in Zod and keep command behavior consistent
  • Review follow-up

    • Replied to unresolved review comments with concrete resolution notes
scopes: z.string().transform((value) => value.split(',').map(String)).alias('s')

Per request in the problem statement, changes were confirmed with npm run build and npm test.

New Command = Five Files

No new command was introduced; this PR updates existing command implementations and specs only.

Main Branch Only

Targets main.

Merge Conflicts

No merge conflicts were present while preparing this update.

Copilot AI changed the title Migrate entra approleassignment and enterpriseapp commands to Zod Address review feedback for Entra Zod migration commands Jun 6, 2026
Copilot AI requested a review from waldekmastykarz June 6, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants