Address review feedback for Entra Zod migration commands#17
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Copilot
AI
changed the title
Migrate entra approleassignment and enterpriseapp commands to Zod
Address review feedback for Entra Zod migration commands
Jun 6, 2026
Copilot created this pull request from a session on behalf of
waldekmastykarz
June 6, 2026 15:42
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Address review feedback for Entra Zod migration commands (
approleassignment*,enterpriseapp*).Linked Issue
Linked automatically by the system.
One PR = One Commit
This update focuses only on requested follow-ups from PR review comments and keeps the migration changes coherent and easy to review.
Schema/test alignment
commandInfo.command.getSchemaToParse() as typeof optionsenterpriseapp-list.spec.tsto include schema-based validation coverageenterpriseapp-get.spec.ts(id+objectId)Scopes parsing normalization
approleassignment-add.tsandapproleassignment-remove.tsto transformscopesin Zod and keep command behavior consistentReview follow-up
Per request in the problem statement, changes were confirmed with
npm run buildandnpm test.New Command = Five Files
No new command was introduced; this PR updates existing command implementations and specs only.
Main Branch Only
Targets
main.Merge Conflicts
No merge conflicts were present while preparing this update.