Skip to content

Ensure AwaitFirstByte is called for all stream inputs to protect interactive prompts #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ev1lm0nk3y wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure AwaitFirstByte is called for all stream inputs to protect interactive prompts #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/moor/moor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ func pagerFromArgs(
var readerImpl *reader.ReaderImpl
var err error

if stdinIsRedirected && inputFilename == "-" {
if inputFilename == "-" {
if stdinDone {
// stdin already drained, don't do it again
continue
Expand All @@ -600,6 +600,8 @@ func pagerFromArgs(

// If the user is doing "sudo something | moor" we can't show the UI until
// we start getting data, otherwise we'll mess up sudo's password prompt.
//
// This also protects the shell prompt if we're doing "moor -".
readerImpl.AwaitFirstByte()

stdinDone = true
Expand Down
Loading