impl lease & cache for buf schema registry#870
Open
jem-davies wants to merge 1 commit into
Open
Conversation
jem-davies
force-pushed
the
lease_protobuf_bsr_pollingleaser
branch
from
May 27, 2026 16:30
dacdaba to
94a5623
Compare
jem-davies
marked this pull request as draft
May 28, 2026 11:05
jem-davies
force-pushed
the
lease_protobuf_bsr_pollingleaser
branch
4 times, most recently
from
May 29, 2026 11:00
a7e2538 to
79a1fe1
Compare
jem-davies
marked this pull request as ready for review
May 29, 2026 13:23
Signed-off-by: Jem Davies <jemsot@gmail.com>
jem-davies
force-pushed
the
lease_protobuf_bsr_pollingleaser
branch
from
May 29, 2026 13:35
1784f7c to
5acd17a
Compare
Collaborator
Author
|
I think that the issue could be being caused by long lived protobuf processors' schemaWatchers not being cancelled / cleaned up ... |
Collaborator
Author
|
Merged
Collaborator
|
@jem-davies Do we still need this following #873 being merged? |
Collaborator
Author
I think it still has value - although perhaps less of a priority after #873 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #861
The protobuf processor allows the setting of a
protobuf.bsrfield which can configure multiple clients to retrieve schemas. As reported on this slack message - there is the potential that a high volume of requests could be sent from Bento and was advised to implement caching such that only one instance will make calls to the registry whilst others will retrieve from the cache.This PR adds two new config fields:
protobuf.bsr.cache-> If set schemas retrieved from the BSR will be saved in a cache resourceprotobuf.bsr.polling_period-> The period in which to poll the Buf Schema Registry.