Adding tests to pr/233

[Roy-vl]

No description provided.

[houndci-bot]

Some files could not be reviewed due to errors:

.eslintrc:

.eslintrc:
	Environment key "es2021" is unknown
Error: .eslintrc:

at /home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-validator.js:144:19

at Array.forEach ()

at validateEnvironment (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-validator.js:140:30)

at Object.validate (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-validator.js:240:5)

at loadFromDisk (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:516:19)

at Object.load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:559:20)

at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:227:44)

at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:179:43)

at Config.getConfigVector (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:286:21)

at Config.getConfig (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:329:29)

[markvantilburg]

@wbotelhos Could you check this?

[wbotelhos]

Hi @markvantilburg , thanks for your PR.

About the current test, I think you're testing an intermediate step that does not prove anything, just that it was called. We need to test the final result which would be this._setIcon(star, icon); call. This call can receive one star or another, depending on the score.

We need a test for _setTitle too, and in this case, we need to test the final value of star.title.