Add comprehensive bond accounts and API integration

.env.example

@@ -55,6 +55,21 @@ TWELVE_DATA_API_KEY=
 # EXCHANGE_RATE_PROVIDER=twelve_data
 # SECURITIES_PROVIDER=twelve_data
 
+# Optional: GUS SDP inflation import for EOD/ROD bonds
+# Disabled by default. Enable only if you want automatic monthly CPI imports.
+INFLATION_IMPORT_ENABLED=false
+# Optional API key for higher GUS SDP limits (free anonymous mode works without it)
+GUS_SDP_API_KEY=
+# Optional: CPI source overrides for US and ES inflation providers
+# US defaults: base_url=https://api.bls.gov/publicAPI/v2, series_id=CUUR0000SA0
+# US_BLS_CPI_BASE_URL=
+# US_BLS_CPI_SERIES_ID=
+# ES defaults: base_url=https://servicios.ine.es/wstempus/js/EN/DATOS_SERIE/
+# ES_INE_CPI_BASE_URL=
+# ES_INE_CPI_SERIES_ID=
+# Optional: override the default CPI indicator series ID used for inflation imports
+# GUS_SDP_CPI_INDICATOR_ID=
+
 # Alternative: Use Yahoo Finance as provider (free, no API key required)
 EXCHANGE_RATE_PROVIDER=yahoo_finance
 SECURITIES_PROVIDER=yahoo_finance

.env.local.example

@@ -24,6 +24,17 @@ ONBOARDING_STATE = open
 # Enable Twelve market data (careful, this will use your API credits)
 TWELVE_DATA_API_KEY =
 
+# Global CPI import for inflation-linked bond calculations
+# Disabled by default; enable only when needed
+INFLATION_IMPORT_ENABLED=false
+# Optional API key (anonymous mode works without this)
+GUS_SDP_API_KEY=
+# Optional CPI provider overrides for US/ES inflation-linked bonds
+# US_BLS_CPI_BASE_URL=
+# US_BLS_CPI_SERIES_ID=
+# ES_INE_CPI_BASE_URL=
+# ES_INE_CPI_SERIES_ID=
+
 # OpenAI-compatible API endpoint config
 OPENAI_ACCESS_TOKEN =
 OPENAI_URI_BASE =

.env.test.example

@@ -32,6 +32,12 @@ OIDC_REDIRECT_URI=http://localhost:3000/auth/openid_connect/callback
 # Uncomment and fill in live keys when you need to generate a VCR cassette fixture
 # ================
 
+# Global CPI import for inflation-linked bond calculations.
+# Leave blank unless you intentionally want ENV to override the persisted setting.
+INFLATION_IMPORT_ENABLED=
+# Optional API key for GUS SDP
+GUS_SDP_API_KEY=
+
 
 # ================
 # Miscellaneous

.github/copilot-instructions.md

@@ -281,3 +281,71 @@ Style for suggestions
 
 Notes from repository config
 - If .gemini/config.yaml disables automated code_review, still provide clear summaries and fix suggestions in PRs.
+
+---
+
+## Bond Feature (PR #1330 - UberDudePL/feature/bond)
+
+### Review context
+- Polish localization PR has already been merged.
+- Do not flag updates in `config/locales/views/**/pl.yml` as out-of-scope by default for Bond follow-up fixes.
+
+### Architecture
+- `Bond` → has many `BondLot` → references inflation provider
+- Subtypes: `zero_coupon`, `fixed_coupon`, `inflation_linked`, `savings`, `other`
+- Product codes: `pl_eod`, `pl_rod`, `us_tips_10y`, `es_letra_3m`, `us_t_bill_4w`
+- Coupon frequency: `at_maturity` (EOD/ROD), `semi_annual` (TIPS), `quarterly`, `monthly`
+
+### Inflation Providers (Pluggable)
+- `gus_sdp` — GUS SDP API (Poland, implemented)
+- `us_bls` — BLS/FRED CPI API (USA, implemented)
+- `es_ine` — INE/Eurostat CPI (Spain, implemented)
+- `nil` — manual CPI entry
+
+### Key Files
+- Models: `app/models/bond.rb`, `app/models/bond_lot.rb`, `app/models/gus_inflation_rate.rb`
+- Controllers: `app/controllers/bonds_controller.rb`, `app/controllers/bond_lots_controller.rb`
+- Tests: `test/models/bond_lot_test.rb`, `test/controllers/bond_lots_controller_test.rb`
+
+---
+
+## Response Style
+
+### Be Concise
+- Short, actionable answers
+- No fluff: avoid "Great question!", "Sure, I'd be happy to help!", "Of course!"
+- First: facts / results. Then details if needed.
+- Don't repeat context already known.
+
+### Tool First
+- Run commands / read files first
+- Then short summary of what happened
+- Then offer next steps if relevant.
+
+### Polish Context
+- User (UberDudePL) prefers Polish language in conversation
+- Code, commits, docs: English only
+- When in doubt, ask.
+
+---
+
+## Caveman-Style Behavior
+
+When working with code:
+1. **Tools first** — run commands, read files, check status
+2. **Then short summary** — 1-3 sentences max
+3. **Then offer action** — if something needs to be done, ask/confirm
+
+Example:
+- Don't: "Great question! Let me check the bond model for you. I'll read the file and analyze it."
+- Do: "Checking bond.rb..." → "Found SUBTYPES at line 15. Want me to refactor to generic version?"
+
+---
+
+## Pre-PR Checklist for Bond Feature
+
+- [ ] Tests pass: `bin/rails test test/models/bond_lot_test.rb`
+- [ ] Tests pass: `bin/rails test test/controllers/bond_lots_controller_test.rb`
+- [ ] Rubocop clean: `bin/rubocop app/models/bond* app/controllers/bond*`
+- [ ] Backfill migration works (eod/rod → inflation_linked + product_code)
+- [ ] US/ES bonds added to PRODUCT_DEFAULTS

.github/workflows/ci.yml

@@ -80,6 +80,8 @@ jobs:
       PLAID_CLIENT_ID: foo
       PLAID_SECRET: bar
       DATABASE_URL: postgres://postgres:postgres@localhost:5432
+      POSTGRES_USER: postgres
+      POSTGRES_PASSWORD: postgres
       REDIS_URL: redis://localhost:6379
       RAILS_ENV: test
 

.gitignore

@@ -98,6 +98,9 @@ node_modules/
 *.ntvs*
 *.njsproj
 *.sln
+
+# Code review comments (local development only)
+bond-comments.md
 *.sw?
 *.roo*
 # OS specific
@@ -123,4 +126,7 @@ scripts/
 .auto-claude-status
 .claude_settings.json
 .security-key
-logs/security/
+logs/security/
+# Local bond implementation notes
+Bond.md
+Bond.txt

app/components/UI/account/activity_feed.html.erb

@@ -26,6 +26,13 @@
                   icon: "arrow-left-right",
                   href: new_trade_path(account_id: account.id),
                   data: { turbo_frame: :modal }) %>
+            <% elsif account.bond? %>
+              <% menu.with_item(
+                  variant: "link",
+                  text: t("accounts.show.activity.new_activity", default: "New activity"),
+                  icon: "arrow-left-right",
+                  href: new_bond_lot_path(account_id: account.id),
+                  data: { turbo_frame: :modal }) %>
             <% else %>
               <% menu.with_item(
                   variant: "link",

app/components/UI/account/chart.html.erb

@@ -4,7 +4,7 @@
       <div class="flex items-center gap-1">
         <%= tag.p title, class: "text-sm font-medium text-secondary" %>
 
-        <% if account.investment? %>
+        <% if account.investment? || account.bond? %>
           <%= render "investments/value_tooltip", balance: account.balance_money, holdings: holdings_value_money, cash: account.cash_balance_money %>
         <% end %>
       </div>
@@ -19,7 +19,7 @@
 
     <%= form_with url: account_path(account), method: :get, data: { controller: "auto-submit-form" } do |form| %>
       <div class="flex items-center gap-2">
-        <% if account.investment? %>
+        <% if account.investment? || account.bond? %>
           <%= form.select :chart_view,
             [["Total value", "balance"], ["Holdings", "holdings_balance"], ["Cash", "cash_balance"]],
             { selected: view },

app/components/UI/account/chart.rb

@@ -28,7 +28,7 @@ def view_balance_money
 
   def title
     case account.accountable_type
-    when "Investment", "Crypto"
+    when "Investment", "Crypto", "Bond"
       case view
       when "balance"
         "Total account value"

app/components/UI/account_page.rb

@@ -33,13 +33,17 @@ def subtitle
   end
 
   def active_tab
+    return :positions if account.bond? && @active_tab&.to_sym == :holdings
+
     tabs.find { |tab| tab == @active_tab&.to_sym } || tabs.first
   end
 
   def tabs
     case account.accountable_type
     when "Investment", "Crypto"
       [ :activity, :holdings ]
+    when "Bond"
+      [ :activity, :positions, :closed ]
     when "Property", "Vehicle", "Loan"
       [ :activity, :overview ]
     else
@@ -51,7 +55,7 @@ def tab_content_for(tab)
     case tab
     when :activity
       activity_feed
-    when :holdings, :overview
+    when :holdings, :overview, :positions, :closed
       # Accountable is responsible for implementing the partial in the correct folder
       render "#{account.accountable_type.downcase.pluralize}/tabs/#{tab}", account: account
     end

app/components/UI/dashboard/bond_summary_row.html.erb

@@ -0,0 +1,31 @@
+<tr class="<%= row_classes %>">
+  <td class="px-4 py-4">
+    <div class="flex items-center gap-4">
+      <%= render DS::FilledIcon.new(variant: :text, text: subtype_label, size: "md", rounded: true) %>
+      <div class="space-y-0.5 min-w-0">
+        <%= link_to subtype_label, account_path(account, tab: "positions"), class: "truncate hover:underline" %>
+        <p class="text-xs text-secondary truncate"><%= t("pages.dashboard.bond_summary.account_wrapper", account: account.name, wrapper: account.bond_wrapper_label || account.short_subtype_label) %></p>
+      </div>
+    </div>
+  </td>
+
+  <td class="px-4 py-4 text-right">
+    <p class="privacy-sensitive"><%= rate_text %></p>
+    <p class="font-normal text-secondary"><%= rate_meta %></p>
+  </td>
+
+  <td class="px-4 py-4 text-right">
+    <p class="privacy-sensitive"><%= helpers.format_money(Money.new(lot.amount, account.currency)) %></p>
+    <p class="font-normal text-secondary"><%= t("pages.dashboard.bond_summary.principal_term", term: t("pages.dashboard.bond_summary.term_months", count: lot.term_months)) %></p>
+  </td>
+
+  <td class="px-4 py-4 text-right">
+    <p class="privacy-sensitive"><%= lot.maturity_date ? l(lot.maturity_date) : t("bonds.purchase_holding.unknown") %></p>
+    <p class="font-normal text-secondary"><%= t("pages.dashboard.bond_summary.maturity_label") %></p>
+  </td>
+
+  <td class="px-4 py-4 text-right">
+    <p class="privacy-sensitive <%= total_return_class %>"><%= helpers.format_money(Money.new(total_return_amount, account.currency)) %></p>
+    <p class="font-normal text-secondary"><%= total_return_label %></p>
+  </td>
+</tr>

app/components/UI/dashboard/bond_summary_row.rb

@@ -0,0 +1,143 @@
+class UI::Dashboard::BondSummaryRow < ApplicationComponent
+  attr_reader :account, :lot, :show_border
+
+  def initialize(account:, lot:, show_border: false)
+    @account = account
+    @lot = lot
+    @show_border = show_border
+  end
+
+  def subtype_label
+    Bond.long_subtype_label_for(lot.subtype) || t("bonds.purchase_holding.unknown")
+  end
+
+  def total_return_amount
+    @total_return_amount ||= projected_total_return? ? projected_return_amount : current_return_amount
+  end
+
+  def total_return_label
+    if projected_total_return?
+      t("bonds.purchase_holding.projected_to_maturity")
+    else
+      t("bonds.purchase_holding.since_purchase")
+    end
+  end
+
+  def total_return_class
+    total_return_amount.negative? ? "text-destructive" : "text-success"
+  end
+
+  def rate_text
+    if lot.inflation_linked?
+      return t("bonds.purchase_holding.update_needed") if lot.requires_rate_review?
+
+      current_rate = lot.current_rate_percent(allow_import: false)
+      return "#{current_rate.round(3)}%" if current_rate.present?
+
+      t("bonds.purchase_holding.unknown")
+    else
+      rate = lot.interest_rate
+      rate.present? ? "#{(rate * 100).round(3)}%" : t("bonds.purchase_holding.unknown")
+    end
+  end
+
+  def rate_meta
+    if lot.inflation_linked?
+      inflation_linked_rate_meta
+    else
+      t(
+        "bonds.purchase_holding.bond_meta",
+        rate_type: localized_rate_type,
+        coupon: localized_coupon_frequency
+      )
+    end
+  end
+
+  def row_classes
+    classes = [ "text-sm", "font-medium", "text-primary" ]
+    classes << "border-b border-divider" if show_border
+    classes.join(" ")
+  end
+
+  private
+    def current_return_amount
+      @current_return_amount ||= lot.total_return_amount(allow_import: false)
+    end
+
+    def projected_return_amount
+      @projected_return_amount ||= lot.projected_total_return_amount(allow_import: false)
+    end
+
+    def projected_total_return?
+      return @projected_total_return if defined?(@projected_total_return)
+
+      @projected_total_return = current_return_amount.abs < 0.01.to_d &&
+        projected_return_amount.positive?
+    end
+
+    def inflation_linked_rate_meta
+      return t("bonds.purchase_holding.pending_review") if lot.requires_rate_review?
+
+      inflation_component = lot.current_inflation_component_percent(allow_import: false)
+      margin_component = lot.current_margin_percent(allow_import: false)
+      if inflation_component.nil? || margin_component.nil?
+        if lot.in_first_rate_period?
+          return t("bonds.purchase_holding.first_period_fixed_rate")
+        else
+          reference_str = lot.current_cpi_reference_on&.strftime("%m-%Y") || t("bonds.purchase_holding.unknown")
+          return t("bonds.purchase_holding.inflation_data_unavailable", reference: reference_str)
+        end
+      end
+
+      inflation = helpers.number_to_percentage(inflation_component.to_d, precision: 3)
+      margin = helpers.number_to_percentage(margin_component.to_d, precision: 3)
+      source = current_inflation_source_key
+
+      if source == "gus_sdp"
+        t(
+          "bonds.purchase_holding.inflation_meta_gus",
+          inflation: inflation,
+          margin: margin,
+          indicator: lot.current_inflation_indicator_id
+        )
+      elsif source.blank? || source == "manual"
+        t(
+          "bonds.purchase_holding.inflation_meta_manual",
+          inflation: inflation,
+          margin: margin
+        )
+      else
+        t(
+          "bonds.purchase_holding.inflation_meta_provider",
+          inflation: inflation,
+          margin: margin,
+          provider: localized_inflation_provider
+        )
+      end
+    end
+
+    def current_inflation_source_key
+      return @current_inflation_source_key if defined?(@current_inflation_source_key)
+
+      @current_inflation_source_key = lot.current_inflation_source(allow_import: false).to_s.presence
+    end
+
+    def localized_inflation_provider
+      provider = current_inflation_source_key
+      return t("bonds.purchase_holding.unknown") if provider.blank?
+
+      t("bonds.purchase_holding.inflation_providers.#{provider}", default: provider.to_s.humanize)
+    end
+
+    def localized_rate_type
+      return t("bonds.purchase_holding.unknown") if lot.rate_type.blank?
+
+      t("bond_lots.form.rate_types.#{lot.rate_type}", default: t("bonds.purchase_holding.unknown"))
+    end
+
+    def localized_coupon_frequency
+      return t("bonds.purchase_holding.unknown") if lot.coupon_frequency.blank?
+
+      t("bond_lots.form.coupon_frequencies.#{lot.coupon_frequency}", default: t("bonds.purchase_holding.unknown"))
+    end
+end