fix(translate): find the first user message past leading system/developer turns - #1078
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix(translate): find the first user message past leading system/developer turns#1078devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Adityakk9031 <Adityakk9031@users.noreply.github.com>
|
PR author is not in the allowed authors list. |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Claude finished @devin-ai-integration[bot]'s task —— View job No comment-length issues found — no added comment block is 3 or more consecutive lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrite of #1073 by @Adityakk9031 to match repo conventions; original credited via
Co-authored-by.FirstUserMessageTextonly looked atmessages.0, so any OpenAI-format body — wheresystem/developerlives inmessages[]— returned"":Consequence in
DeriveSessionKey: with no first-user text the discriminator fell back toSystemText(), so two unrelated Codex/OpenAI conversations sharing one system prompt under one API key hashed to the same session key and thrashed a single pin slot.geminiFirstUserMessageTextalready scanned for the first user turn, so this also removes a per-format inconsistency.Also updates the now-stale
DeriveSessionKeycomments, which documented the old "first user message is empty on OpenAI bodies" fallback rationale — #1073 left them describing behavior that no longer exists.Note: OpenAI-format session keys change value, so existing pins for those sessions are invalidated once on deploy.
Dropped from the original: an unrelated hunk in
internal/proxy/conformance_golden_test.gothat CRLF-normalized both sides of the golden comparison. No golden fixture in the repo contains CRLF; that is a Windows-checkout (core.autocrlf) workaround which permanently weakens the assertion.Validation
make precommitgreen;gofmt -l ./internal ./cmdcleango test ./internal/translate/... ./internal/proxy/... ./internal/router/turntype/...TestDeriveSessionKey_OpenAISharedSystemDifferentUserPromptDoesNotCollidefails onmain(identical digests) and passes hereLink to Devin session: https://app.devin.ai/sessions/ed6a7cbbb8c4489d8c056590b3cc174b
Open in Devin Desktop: https://app.devin.ai/desktop/session/ed6a7cbbb8c4489d8c056590b3cc174b?variant=devin
Requested by: @steventohme