feat: add source.enableAsyncPreEntry for async entry#8546
Open
feat: add source.enableAsyncPreEntry for async entry#8546
Conversation
🦋 Changeset detectedLatest commit: b2c9dff The changes in this PR will be included in the next version bump. This PR includes changesets to release 117 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Rsdoctor Bundle Diff Analysis📊 Quick Summary
Generated by Rsdoctor GitHub Action |
b68b14b to
b2c9dff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
source.enableAsyncPreEntryconfigsource.enableAsyncEntryis turned onsource.preEntryimports at the top of generatedindex.jsxsource.preEntryto builder when async pre-entry handling is enabledDetails
When
source.enableAsyncEntryis enabled, the final build entry becomesbootstrap.jsx, so builder-sidesource.preEntrydoes not reliably affect the real entry code.This change introduces
source.enableAsyncPreEntryto handle that case in Modern.js entry generation:bootstrap.jsxremains the async boundaryindex.jsxbecomes the place wherepreEntryimports are injectedpreEntryruns before the real entry logic in async entry scenariosTesting
preEntryis injected intoindex.jsxbootstrap.jsxdoes not containpreEntrypreEntrycode is executed in the browser