Rename dangling-markup-window-name test#41718
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Aug 30, 2023
Merged
Conversation
wpt-pr-bot
approved these changes
Aug 30, 2023
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4827645
branch
from
2f5107c to
0a9f57b
Compare
Since the dangling markup in target name is merged to the html spec[1], let's remove the tentative name from the test. [1] whatwg/html#9309 Bug: 1421440 Change-Id: I75a47e0c155cd81f72eafe45a9118a93b8904ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4827645 Auto-Submit: Jun Kokatsu <jkokatsu@google.com> Reviewed-by: Yifan Luo <lyf@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Commit-Queue: Jun Kokatsu <jkokatsu@google.com> Cr-Commit-Position: refs/heads/main@{#1190256}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4827645
branch
from
0a9f57b to
52cf5c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the dangling markup in target name is merged to the html spec[1],
let's remove the tentative name from the test.
[1] whatwg/html#9309
Bug: 1421440
Change-Id: I75a47e0c155cd81f72eafe45a9118a93b8904ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4827645
Auto-Submit: Jun Kokatsu <jkokatsu@google.com>
Reviewed-by: Yifan Luo <lyf@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Commit-Queue: Jun Kokatsu <jkokatsu@google.com>
Cr-Commit-Position: refs/heads/main@{#1190256}