Skip to content

[WebCryptoAPI] Fix tests of SHA3 and cSHAKE with mutated buffers #57616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twiss merged 1 commit into from
Mar 10, 2026
Merged

[WebCryptoAPI] Fix tests of SHA3 and cSHAKE with mutated buffers #57616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions WebCryptoAPI/digest/cshake.tentative.https.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,16 +195,17 @@ Object.keys(digestedData).forEach(function (alg) {

promise_test(function (test) {
var buffer = new Uint8Array(sourceData[size]);
return crypto.subtle
var promise = crypto.subtle
.digest({ name: alg, length: length }, buffer)
.then(function (result) {
// Alter the buffer after calling digest
buffer[0] = ~buffer[0];
assert_true(
equalBuffers(result, digestedData[alg][length][size]),
'digest matches expected'
);
});
// Alter the buffer after calling digest
buffer[0] = ~buffer[0];
return promise;
}, alg + ' with ' + length + ' bit output and ' + size + ' source data and altered buffer after call');
}
});
Expand Down
7 changes: 4 additions & 3 deletions WebCryptoAPI/digest/sha3.tentative.https.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,15 @@ Object.keys(sourceData).forEach(function (size) {

promise_test(function (test) {
var buffer = new Uint8Array(sourceData[size]);
return crypto.subtle.digest(alg, buffer).then(function (result) {
// Alter the buffer after calling digest
buffer[0] = ~buffer[0];
var promise = crypto.subtle.digest(alg, buffer).then(function (result) {
assert_true(
equalBuffers(result, digestedData[alg][size]),
'digest matches expected'
);
});
// Alter the buffer after calling digest
buffer[0] = ~buffer[0];
return promise;
}, alg + ' with ' + size + ' source data and altered buffer after call');
}
});
Expand Down