Rename OpaqueRange getValueRange() to createValueRange()#58079
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Feb 26, 2026
Merged
Rename OpaqueRange getValueRange() to createValueRange()#58079chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7595653
branch
from
1d99542 to
9f4d92c
Compare
The new name makes it explicitly clear that a new range is created each time, as suggested in HTML spec PR discussion: whatwg/html#11741 (comment) Updates the OpaqueRangeCreation mixin and IDL, all implementing classes (TextControlElement, HTMLInputElement), and test files. Low-Coverage-Reason: COVERAGE_UNDERREPORTED Bug: 421421332 Change-Id: Iec9572c470443e85d2a38ecd978bd7c78e8c5a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7595653 Reviewed-by: Dan Clark <daniec@microsoft.com> Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Ana Sollano Kim <ansollan@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1591036}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7595653
branch
from
9f4d92c to
48278d9
Compare
wpt-pr-bot
approved these changes
Feb 26, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new name makes it explicitly clear that a new range is created each
time, as suggested in HTML spec PR discussion:
whatwg/html#11741 (comment)
Updates the OpaqueRangeCreation mixin and IDL, all implementing classes
(TextControlElement, HTMLInputElement), and test files.
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Bug: 421421332
Change-Id: Iec9572c470443e85d2a38ecd978bd7c78e8c5a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7595653
Reviewed-by: Dan Clark <daniec@microsoft.com>
Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Ana Sollano Kim <ansollan@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1591036}