Support attribute API for processing instructions#58294
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Mar 5, 2026
Merged
Support attribute API for processing instructions#58294chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
Add setAttribute/getAttribute/hasAttribute/removeAttribute etc. to ProcessingInstruction. They act similarly to attributes on elements, however they don't produce attribute mutation records. See spec PR: whatwg/dom#1454 Bug: 431374376 Change-Id: I659e772f0fb11a6ffe2fe3876cf61ee0f6ad042a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7607900 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Cr-Commit-Position: refs/heads/main@{#1594810}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7607900
branch
from
b0b5206 to
23f2fa8
Compare
wpt-pr-bot
approved these changes
Mar 5, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add setAttribute/getAttribute/hasAttribute/removeAttribute etc. to
ProcessingInstruction. They act similarly to attributes on elements,
however they don't produce attribute mutation records.
See spec PR: whatwg/dom#1454
Bug: 431374376
Change-Id: I659e772f0fb11a6ffe2fe3876cf61ee0f6ad042a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7607900
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@google.com>
Cr-Commit-Position: refs/heads/main@{#1594810}