[focusgroup] Exclude top-layer elements from ancestor navigation.#59564
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Apr 30, 2026
Merged
[focusgroup] Exclude top-layer elements from ancestor navigation.#59564chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
Elements in the top layer (popovers, modal dialogs, fullscreen) were participating in ancestor focusgroup navigation. Per the scoped focusgroup explainer's "Top layer elements" section, they should be excluded while they remain in the top layer, matching focusgroup="none" semantics for arrow keys, segment boundaries, and memory eligibility. See: https://open-ui.org/components/scoped-focusgroup.explainer/#top-layer-elements) A top-layer element's own focusgroup still works normally; only ancestor participation is affected. Also fix the AX item role inference path in ax_object.cc, which called FindFocusgroupOwner directly and could infer roles from an ancestor focusgroup across a top-layer boundary. Remove the now-unused IsInExplicitlyOptedOutSubtree. Bug: 4021071 Change-Id: Ib1e051648e0e3555026f1692753c3e731ab694b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7792136 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1622904}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7792136
branch
from
202a431 to
624b999
Compare
wpt-pr-bot
approved these changes
Apr 30, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elements in the top layer (popovers, modal dialogs, fullscreen) were
participating in ancestor focusgroup navigation. Per the scoped
focusgroup explainer's "Top layer elements" section, they should be
excluded while they remain in the top layer, matching focusgroup="none"
semantics for arrow keys, segment boundaries, and memory eligibility.
See:
https://open-ui.org/components/scoped-focusgroup.explainer/#top-layer-elements)
A top-layer element's own focusgroup still works normally; only ancestor
participation is affected.
Also fix the AX item role inference path in ax_object.cc, which called
FindFocusgroupOwner directly and could infer roles from an ancestor
focusgroup across a top-layer boundary. Remove the now-unused
IsInExplicitlyOptedOutSubtree.
Bug: 4021071
Change-Id: Ib1e051648e0e3555026f1692753c3e731ab694b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7792136
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1622904}