wptserve: detect TLS ClientHello on non-TLS HTTP server#59569
Open
gsnedders wants to merge 1 commit intoweb-platform-tests:masterfrom
Open
wptserve: detect TLS ClientHello on non-TLS HTTP server#59569gsnedders wants to merge 1 commit intoweb-platform-tests:masterfrom
gsnedders wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
When a browser, e.g. one that does HTTPS-by-default, sends a TLS ClientHello to our (non-TLS) HTTP port, the binary data falls through into parse_request() which emits confusing "Bad HTTP/0.9 request type" and "Bad request version" warnings with garbled binary characters, and then loops reading further into the TLS record body. Instead, we detect the ClientHello and log one info-level message before closing the connection. Fixes: web-platform-tests#51342
wpt-pr-bot
requested review from
DanielRyanSmith,
foolip,
jgraham and
jonathan-j-lee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a browser, e.g. one that does HTTPS-by-default, sends a TLS
ClientHello to our (non-TLS) HTTP port, the binary data falls through
into parse_request() which emits confusing "Bad HTTP/0.9 request type"
and "Bad request version" warnings with garbled binary characters, and
then loops reading further into the TLS record body.
Instead, we detect the ClientHello and log one info-level message
before closing the connection.
Fixes: #51342