Skip to content

Update dangling markup mitigations.#6033

Closed
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-export-cl-Ifda61a0afe1f0e97620acef7dc54b005c6f74840
Closed

Update dangling markup mitigations.#6033
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-export-cl-Ifda61a0afe1f0e97620acef7dc54b005c6f74840

Conversation

@chromium-wpt-export-bot
Copy link
Copy Markdown
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 24, 2017

Update dangling markup mitigations.

Still behind a flag, just updating the checks to look for both \n and
< rather than just the former. This is in line with the patches up at
whatwg/url#284 and
whatwg/fetch#519.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KaA_YNOlTPk/VmmoV88xBgAJ.

Bug: 680970
Change-Id: Ifda61a0afe1f0e97620acef7dc54b005c6f74840
Reviewed-on: https://chromium-review.googlesource.com/514024
Commit-Queue: Mike West mkwst@chromium.org
Reviewed-by: Jochen Eisinger jochen@chromium.org
Cr-Commit-Position: refs/heads/master@{#474292}
WPT-Export-Revision: 8f0c33883ba9ad137a9ed9fe8a758022230f3e06

Copy link
Copy Markdown
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@ghost
Copy link
Copy Markdown

ghost commented May 24, 2017

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 112cbdf
Using browser at version BuildID 20170524100215; SourceStamp 291a11111bdd05c5cd55dd552da4b1285ceba9b2
Starting 10 test iterations
All results were stable

All results

1 test ran
/fetch/dangling-markup-mitigation.tentative.html
Subtest Results Messages
OK
Fetch: /images/green-1x1.png PASS
Fetch: /images/gre\nen-1x1.png PASS
Fetch: /images/gre\ten-1x1.png PASS
Fetch: /images/gre\ren-1x1.png PASS
Fetch: /images/green-1x1.png?img=< PASS
Fetch: /images/green-1x1.png?img=&lt; PASS
Fetch: /images/green-1x1.png?img=%3C PASS
Fetch: /images/gr\neen-1x1.png?img=%3C PASS
Fetch: /images/gr\reen-1x1.png?img=%3C PASS
Fetch: /images/gr\teen-1x1.png?img=%3C PASS
Fetch: /images/green-1x1.png?img=&#10; PASS
Fetch: /images/gr\neen-1x1.png?img=&#10; PASS
Fetch: /images/gr\reen-1x1.png?img=&#10; PASS
Fetch: /images/gr\teen-1x1.png?img=&#10; PASS
Fetch: /images/gre\nen-1x1.png?img=< FAIL assert_unreached: Fetch should fail. Reached unreachable code
Fetch: /images/gre\ren-1x1.png?img=< FAIL assert_unreached: Fetch should fail. Reached unreachable code
Fetch: /images/gre\ten-1x1.png?img=< FAIL assert_unreached: Fetch should fail. Reached unreachable code
Fetch: /images/green-1x1.png?<\n=block FAIL assert_unreached: Fetch should fail. Reached unreachable code
Fetch: /images/green-1x1.png?<\r=block FAIL assert_unreached: Fetch should fail. Reached unreachable code
Fetch: /images/green-1x1.png?<\t=block FAIL assert_unreached: Fetch should fail. Reached unreachable code
<img id="dangling" src="/images/green-1x1.png?img=&lt;b"> PASS
<img id="dangling" src="/images/green-1x1.png?img=&#10;b"> PASS
<img id="dangling" src="/images/green-1x1.png?img=&amp;#10;b"> PASS
<img id="dangling" src="/images/green-1x1.png?img=&amp;lt;b"> PASS
<img id="dangling" src="/images/green-1x1.png?img=&amp;#10;b&amp;lt;c"> PASS
\n <img id="dangling" src="\n /images/green-1x1.png?img= \n ">\n PASS
\n <img id="dangling" src="\n /images/green-1x1.png?img=&amp;lt;\n ">\n PASS
\n <img id="dangling" src="\n /images/green-1x1.png?img=&amp;#10;\n ">\n PASS
<img id="dangling" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII="> PASS
<img id="dangling" src="data:image/png;base64,&#10;iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII="> PASS
<img id="dangling" src="data:image/png;base64,i&#10;VBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII="> PASS
<img id="dangling" src="data:image/svg+xml;utf8,\n <svg width='1' height='1' xmlns='http://www.w3.org/2000/svg'>\n <rect width='100%' height='100%' fill='rebeccapurple'/>\n <rect x='10%' y='10%' width='80%' height='80%' fill='lightgreen'/>\n </svg>"> PASS
<img id="dangling" src="/images/green-1x1.png?img=&#10;&lt;b"> FAIL assert_equals: Height expected 0 but got 1
<img id="dangling" src="/images/green-1x1.png?img=&lt;&#10;b"> FAIL assert_equals: Height expected 0 but got 1
\n <img id="dangling" src="/images/green-1x1.png?img=\n &lt;\n &#10;b\n ">\n FAIL assert_equals: Height expected 0 but got 1

@ghost
Copy link
Copy Markdown

ghost commented May 24, 2017

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 112cbdf
Using browser at version 10.0
Starting 10 test iterations

@ghost
Copy link
Copy Markdown

ghost commented May 24, 2017

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 112cbdf
Using browser at version 60.0.3107.4 dev
Starting 10 test iterations

@ghost
Copy link
Copy Markdown

ghost commented May 24, 2017

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 112cbdf

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-Ifda61a0afe1f0e97620acef7dc54b005c6f74840 branch 2 times, most recently from 6afc57f to 45f65fd Compare May 24, 2017 15:14
Still behind a flag, just updating the checks to look for both `\n` and
`<` rather than just the former. This is in line with the patches up at
whatwg/url#284 and
whatwg/fetch#519.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KaA_YNOlTPk/VmmoV88xBgAJ.

Bug: 680970
Change-Id: Ifda61a0afe1f0e97620acef7dc54b005c6f74840
Reviewed-on: https://chromium-review.googlesource.com/514024
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474292}
WPT-Export-Revision: 8f0c33883ba9ad137a9ed9fe8a758022230f3e06
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-Ifda61a0afe1f0e97620acef7dc54b005c6f74840 branch from 45f65fd to 647e713 Compare May 24, 2017 15:23
@jeffcarp jeffcarp closed this May 24, 2017
@Hexcles Hexcles deleted the chromium-export-cl-Ifda61a0afe1f0e97620acef7dc54b005c6f74840 branch December 12, 2017 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants