Update dangling markup mitigations.#6033
Closed
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Closed
Update dangling markup mitigations.#6033chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
May 24, 2017
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
Firefox (nightly)Testing web-platform-tests at revision 112cbdf All results1 test ran/fetch/dangling-markup-mitigation.tentative.html
|
Sauce (safari)Testing web-platform-tests at revision 112cbdf |
Chrome (unstable)Testing web-platform-tests at revision 112cbdf |
Sauce (MicrosoftEdge)Testing web-platform-tests at revision 112cbdf |
6afc57f to
45f65fd
Compare
Still behind a flag, just updating the checks to look for both `\n` and `<` rather than just the former. This is in line with the patches up at whatwg/url#284 and whatwg/fetch#519. Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KaA_YNOlTPk/VmmoV88xBgAJ. Bug: 680970 Change-Id: Ifda61a0afe1f0e97620acef7dc54b005c6f74840 Reviewed-on: https://chromium-review.googlesource.com/514024 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#474292} WPT-Export-Revision: 8f0c33883ba9ad137a9ed9fe8a758022230f3e06
45f65fd to
647e713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dangling markup mitigations.
Still behind a flag, just updating the checks to look for both
\nand<rather than just the former. This is in line with the patches up atwhatwg/url#284 and
whatwg/fetch#519.
Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KaA_YNOlTPk/VmmoV88xBgAJ.
Bug: 680970
Change-Id: Ifda61a0afe1f0e97620acef7dc54b005c6f74840
Reviewed-on: https://chromium-review.googlesource.com/514024
Commit-Queue: Mike West mkwst@chromium.org
Reviewed-by: Jochen Eisinger jochen@chromium.org
Cr-Commit-Position: refs/heads/master@{#474292}
WPT-Export-Revision: 8f0c33883ba9ad137a9ed9fe8a758022230f3e06