Skip to content

fix(types): correct intersection, indexedAccess, and add predicate/templateLiteral #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sujalgoel wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(types): correct intersection, indexedAccess, and add predicate/templateLiteral #66

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a982cb8
fix(types): correct intersection, indexedAccess, and add predicate/te…
sujalgoel Mar 29, 2026
ead003e
chore: regenerate pages with corrected type rendering
sujalgoel Mar 29, 2026
eee06ec
fix(types): simplify predicate to target type, remove templateLiteral
sujalgoel Mar 29, 2026
342092f
chore: bump @node-core/doc-kit to 1.3.0, regenerate pages
sujalgoel Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions plugins/theme/partials/types.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,29 @@ const resolve = type => {
return `Tuple<${union(type.elements, ', ')}>`;

case 'union':
case 'intersection':
return union(type.types);

case 'intersection':
return union(type.types, '&');

case 'optional':
return resolve(type.elementType);

case 'indexedAccess':
return resolve(type.elementType ?? type.objectType);
return `${resolve(type.objectType)}[${resolve(type.indexType)}]`;

case 'predicate': {
const target = type.targetType ? ` is ${resolve(type.targetType)}` : '';
return (type.asserts ? 'asserts ' : '') + type.name + target;
}
Copy link
Copy Markdown
Member

@avivkeller avivkeller Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just return the target, perhaps


case 'templateLiteral':
return (
'`' +
type.head +
type.tail.map(([t, s]) => '${' + resolve(t) + '}' + s).join('') +
'`'
);
Copy link
Copy Markdown
Member

@avivkeller avivkeller Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert


case 'query':
return resolve(type.queryType);
Expand Down
Loading