fix: Look for active breaks in right ModBreaks#298
Merged
Conversation
Helps when debugging the debugger!
In `getActiveBreakpoints`, we were incorrectly looking up the occurence module of an internal breakpoint id (`getBreakSourceMod`) on the `InternalModBreaks` of a different module (`readIModBreaksMaybe` of the argument module, not the internal breakpoint id one)! That is just plain incorrect... The `activeBreakpoints` map stores the active internal-breakpoint-ids. To get the active breakpoints at module A, we find the *occurrence module* for every internal breakpoint id in `activeBreakpoints` and keep the ones whose occurrence module matches the argument module (recall: a breakpoint defined in B may be inlined in A, which means `getBreakSourceMod` will return `A` -- and that's what we want to match against the argument module) (See also Note [ModBreaks vs InternalModBreaks] and Note [Breakpoint identifiers] in GHC) Fixes #297
7beaf3b to
2eb4587
Compare
This output required updating everytime a module was added or removed, as was very prone to conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #297