-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add HTML-in-Canvas APIs #11588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
foolip
wants to merge
66
commits into
main
Choose a base branch
from
foolip/html-in-canvas
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+768
−2
Open
Add HTML-in-Canvas APIs #11588
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
e181de1
Stub out canvas.drawElement()
foolip 8634ebe
Fix typ: y->h
foolip afc4a4d
Modernize the style somewhat
foolip f151c83
Replace handwavy check with real check and drop "update the rendering"
foolip 74d67ae
Add the layoutsubtree attribute
foolip f7d320a
Rename to drawHTMLElement()
foolip 3cad6d4
Fix the layoutsubtree UA style sheet
foolip 4367aac
Rename to drawElementImage()
foolip 84ec8e6
Define sensitive information
foolip f351c3d
Expose children to AT
foolip aed994e
grammar
foolip 8c3ce46
Use containment to make children containing blocks
foolip ff066c9
Define setHitTestRegions()
foolip 5e3c3d0
Merge remote-tracking branch 'origin/main' into foolip/html-in-canvas
foolip f8f119a
Wrap algorithms
foolip 202adae
Fix typo and reserved word
foolip be22310
Add a note about not using CTM
foolip 9866034
Fix reference to hit test regions
foolip 4e559a9
Skip non-positive width/height regions
foolip 4838669
Use CSS border box
foolip 9fa39e9
Replace hit testing API with a simpler model
foolip f79ed95
Add a hit testing example
foolip 0a243be
Add getElementTransform() and related algorithms
foolip 1f71b9a
Update drawElementImage() to return matrix
foolip 5aeb03b
Express the transformations in a more approachable way
foolip 951bdee
Address progers feedback
foolip ba5c560
<data> -> <code>
foolip 4d77e94
Use [Reflect] for layoutSubtree
foolip d033976
Link DOMMatrix
foolip b953591
Merge remote-tracking branch 'origin/main' into foolip/html-in-canvas
foolip a852071
Flesh out sensitive information a little bit
foolip 5b5dc3d
Add canvas paint event
foolip 49184b4
Define rendering with an internal shadow tree
foolip 8d0edfc
Update and move example
foolip 0480023
Merge remote-tracking branch 'origin/main' into foolip/html-in-canvas
foolip ffe1e1e
Replace example with pie chart
foolip bc57d89
Flesh out domintro and move algorithms
foolip 00b5bf9
Add requestPaint()
foolip 769de4c
better define timing using a snapshots concept
foolip ab2ee8f
Add OffscreenCanvas support
foolip b2cd7a3
a->an
foolip 4096cbc
Move layoutsubtree check to when snapshots are created
foolip 3ccf75f
Address @Kaiido feedback (thank you!)
foolip a27ade2
Move and polish the sensitive information dfn
foolip f3b7fe0
Overhaul OffscreenCanvas algorithms
foolip bd7a35c
Make ElementImage transferrable (no paint event in OffscreenCanvas)
foolip 46273d9
Add missing return
foolip d9c4769
Add explicit steps and notes about painting
foolip e3965e6
Clarify that the canvas element layout cannot change
foolip 12f02aa
Add source rect variants
foolip 0a158e6
CanvasPaintEvent's changedElements can only be Element
foolip 2df6477
Capture the scaling factor when creating snapshots
foolip c5e2815
Subpixel rendering is sensitive information
foolip 2850d56
Say that selection and find-in-page highlight colors are sensitive
foolip f4f738b
Remove ElementImage's id
foolip 09b811d
Add ElementImage close() method
foolip 542723b
Throw on drawing a detached ElementImage
foolip 7aee3ee
Make ElementImage width/height double
foolip 2c95e37
Make non-default fonts sensitive information
foolip 0a476ef
Don't expose platform-specific form appearance
foolip 71347b5
Require snapshots to be scalable (not bitmaps)
foolip 22b725e
Disallow same-origin nesting of canvas elements
foolip 959ca6b
Replace shadow tree bits with simpler rendering rules
foolip 3350248
Remove stray quotes
foolip cb6c69d
Merge remote-tracking branch 'origin/main' into foolip/html-in-canvas
foolip ae964a9
Add layout containment
foolip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.