Skip to content

Make option and optgroup actually disabled inside disabled select #12205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josepharhar wants to merge 6 commits into
base: main
Choose a base branch
from
+11 −6
Open

Make option and optgroup actually disabled inside disabled select #12205

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e2c274
Fix select option disabled selector
josepharhar Feb 26, 2026
cefa390
Merge branch 'main' into disabledhover
josepharhar Apr 13, 2026
0b4dbe8
Make actually disabled depend on ancestor select
josepharhar Apr 13, 2026
01b1944
make same fix for optgroup
josepharhar Apr 16, 2026
ac4011b
fix optgroup ancestors
josepharhar Apr 25, 2026
7b78ae3
rename algorithm
josepharhar Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79215,9 +79215,13 @@ contradict people?

<li>a <code>textarea</code> element that is <span data-x="concept-fe-disabled">disabled</span></li>

<li>an <code>optgroup</code> element that has a <code data-x="attr-optgroup-disabled">disabled</code> attribute</li>
<li>an <code>optgroup</code> element that has a <code
Copy link
Copy Markdown
Member

@annevk annevk Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix this at the same time?

Copy link
Copy Markdown
Contributor Author

@josepharhar josepharhar Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

data-x="attr-optgroup-disabled">disabled</code> attribute or whose nearest <span>ancestor</span>
<code>select</code> element is <span data-x="concept-fe-disabled">disabled</span></li>
Copy link
Copy Markdown
Member

@annevk annevk Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the same definition for ancestor select that we have for option? We probably want to exclude the same set of intermediate elements, no?

Copy link
Copy Markdown
Contributor Author

@josepharhar josepharhar Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done


Copy link
Copy Markdown
Member

@annevk annevk Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to generalize the nearest ancestor select algorithm for this to work as currently this results in a type error. You're handing an optgroup to something that wants an option.

Copy link
Copy Markdown
Contributor Author

@josepharhar josepharhar Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I changed the parameter from option to element

<li>an <code>option</code> element that is <span data-x="concept-option-disabled">disabled</span></li>
<li>an <code>option</code> element that is <span data-x="concept-option-disabled">disabled</span>
or whose <span data-x="option element nearest ancestor select">nearest ancestor
<code>select</code></span> is <span data-x="concept-fe-disabled">disabled</span></li>

<li>a <code>fieldset</code> element that is a <span data-x="concept-fieldset-disabled">disabled fieldset</span></li>

Expand Down
Loading