Accept BigInt as input format#4
Open
dtamayo-nlp wants to merge 1 commit into
Open
Conversation
|
It would be more meaningful to just change this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank @wildart for driving this forward.
I only have a quick comment. I was testing this algorithm for big matrices and I found the necessity of using the BigInt format to avoid a "DivideError: integer division error" in line 12 of bezout.jl (click Issue for more information).
The problem was that this format is not accepted in your code because "there is no method matching typemax(::Type{BigInt})". I have adapted the use of "typemax" in one part of the code to accept it.
I hope you find it useful.