fix: add bounds check for current_idx in AE response handler#127
Open
Qian-Cheng-nju wants to merge 3 commits intowillemt:masterfrom
Open
fix: add bounds check for current_idx in AE response handler#127Qian-Cheng-nju wants to merge 3 commits intowillemt:masterfrom
Qian-Cheng-nju wants to merge 3 commits intowillemt:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I found a crash in the AppendEntries response handler and put together a fix.
When a peer sends an AE response with current_idx larger than the leader's log length, raft_get_entry_from_idx returns NULL and the code dereferences it (ety->term), crashing the process. The existing assert at line 366 catches this in debug builds, but it's compiled out in release.
The fix adds a proper bounds check so out-of-range current_idx is handled gracefully instead of crashing.