Skip to content

Fix issue with nodes not promoted to voting. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yossigo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue with nodes not promoted to voting. #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/raft_server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ void raft_clear(raft_server_t* me_)
me->last_applied_idx = 0;
me->num_nodes = 0;
me->node = NULL;
me->voting_cfg_change_log_idx = 0;
log_clear(me->log);
}

Expand Down Expand Up @@ -810,8 +809,11 @@ int raft_apply_entry(raft_server_t* me_)
return RAFT_ERR_SHUTDOWN;
}

/* voting cfg change is now complete */
if (log_idx == me->voting_cfg_change_log_idx)
/* voting cfg change is now complete.
* TODO: there seem to be a possible off-by-one bug hidden here, requiring
* checking log_idx >= voting_cfg_change_log_idx rather than plain ==.
*/
if (log_idx >= me->voting_cfg_change_log_idx)
me->voting_cfg_change_log_idx = -1;

if (!raft_entry_is_cfg_change(ety))
Expand Down